zanduino / bme280 Goto Github PK

The Default value of 100KHz should be able to be overridden by the library user

In methods getdata and putdata in BME280.h, the communication method (I2C, SPI, soft SPI) is chosen at run time. This causes the respective code and libraries always to be included, using valuable memory.

My suggestion would be to select any or all of these methods by means of #define at compile time. For most users, a single method would suffice, while the default (to maintain compatibility and allow for multiple sensors with different comms methods) could be support for all three.

What's your take on this? I'm happy to provide code once my board has arrived and works with the current version.

In the file "BME280.h" there is a while-loop with a timout after the Wire.requestFrom(). That while-loop can be removed. There is nothing to wait for. When the Wire.requestFrom() returns, the I2C transaction has completely finished.

Hi,
while waiting for my BME280 board to arrive (so I couldn't test yet), I've browsed through your library and may have stumbled upon a glitch in BME280_Class::iirFilter.

According to the data sheet, table 26 on page 28 (also table 18 on page 25), IIR filter values are in bits 4,3,2 of the config register. In line 289 of BME280.cpp however, the bit mask is

returnValue = returnValue&B11110001; // Get control reg, mask IIR bits

while all other register values are left or right shifted by 2 (as expected). Shouldn't it be

returnValue = returnValue&B11100011; // Get control reg, mask IIR bits

or am I missing something here?

Convert the example program and library sources to doxygen documentation standards

Clean up the Directory structure and file names