Giter Club home page Giter Club logo

Comments (7)

szuecs avatar szuecs commented on August 25, 2024 1

@lukibahr That would be a feature to support which makes a lot of sense!
In skipper we would use read from file via our secrets module.

from skipper.

AlexanderYastrebov avatar AlexanderYastrebov commented on August 25, 2024 1

Looks like duplicate of #1952

from skipper.

lukibahr avatar lukibahr commented on August 25, 2024

@szuecs Is there a reference implementation already in skipper where we use the secrets module?

from skipper.

szuecs avatar szuecs commented on August 25, 2024

In many auth filters it is in use or also in net/Client (skipper's http client)

from skipper.

lukibahr avatar lukibahr commented on August 25, 2024

@szuecs Is there any chance to get this implemented in the next couple of days or weeks? I'm currently not familiar enough with the entire codebase, to get this implemented and propose a MR for this.

Thanks

from skipper.

szuecs avatar szuecs commented on August 25, 2024

MR?

I will have holidays until January, so I am not really available next days.
Maybe I can give a bit of context to the code. We implement these kind of features in filters.
Filters are created by an instance of a "spec". You likely want to create a new spec for this similar to the others (share spec with different new kind of "typ").
A filter instance is created by CreateFilter().

The entry point of the code that does the call path to work on the request is https://github.com/zalando/skipper/blob/master/filters/auth/oidc.go#L756.

from skipper.

lukibahr avatar lukibahr commented on August 25, 2024

I will have a look into it, after getting familiar with the codebase.

from skipper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.