Giter Club home page Giter Club logo

Comments (3)

AlexanderYastrebov avatar AlexanderYastrebov commented on August 25, 2024 1

As a workaround you may try adding default filters like so:

-default-filters-prepend='copyRequestHeader("X-Flux-Id", "X-Flow-Id") -> dropHeader("X-Flux-Id")'
-default-filters-append='copyRequestHeader("X-Flow-Id", "X-Flux-Id") -> dropHeader("X-Flow-Id")'

from skipper.

wndhydrnt avatar wndhydrnt commented on August 25, 2024 1

Tested the workaround today. It correctly sets the new header, X-Flux-Id, but the field flow-id in the access logs stays empty.
My guess is that this happens because the write of the access log is deferred here and therefore happens after all filters have been processed already.

While looking into this, I noticed that it is possible to add custom fields to the access log through a filter via the AccessLogAdditionalDataKey of the state bag. A custom filter can set its own value of the field flow-id, which is an acceptable workaround for this issue.

Closing the issue for now.

from skipper.

AlexanderYastrebov avatar AlexanderYastrebov commented on August 25, 2024

@wndhydrnt Thank your for the feedback. I think you are right regarding access logs, you may try default-filters-append without dropHeader("X-Flow-Id")' with a caveat that backend will see X-Flow-Id header which might be not a big deal really.

from skipper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.