zaininnari / html-minifier Goto Github PK

I get this warning multiple times when using html-minifier after upgrading to PHP 7.3.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in ...
[....]/vendor/zaininnari/html-minifier/src/zz/Html/HTMLTokenizer.php on line xyz

https://wiki.php.net/rfc/continue_on_switch_deprecation

kirby-deprecated-plugins/kirby-html-minifier#5

I use this for a plugin in Kirby CMS. Inline svg seems to fail.

Hi,

Your minifier is one of the most awesome I could find ! Thanks a lot for this job !
However, I had a little trouble using advanced optimisation option.

For that kind of html :

<p>Here is some <strong>bold</strong> text</p>

It will output :

<p>Here is some<strong>bold</strong>text</p>

I also made a test with more inline tags

<p>
    And here is some <strong>bold</strong> with <b>b</b> tag.
    Hey, what about <em>emphasis</em> and <i>italic</i> ?
    And also <u>underline</u> string ?!
</p>

Which gave me this :

<p>And here is some<strong>bold</strong> with <b>b</b> tag.
Hey, what about <em>emphasis</em> and <i>italic</i> ?
And also <u>underline</u>string ?!</p>

Considering that the standard optimisation level works fine, I fixed it using this code I'm not really proud of :

$minifier = new \zz\Html\HTMLMinify($html, array(
    'doctype'               => \zz\Html\HTMLMinify::DOCTYPE_HTML5,
    'optimizationLevel'     => \zz\Html\HTMLMinify::OPTIMIZATION_ADVANCED,
));
$minified = $minifier->process();
$lines = preg_split('/(\r\n|\n)/', $minified);

$minified = '';
$forceNewLine = false;
foreach($lines as $line) {

    // For now an then add new line characters after this one
    if(mb_strpos($line, '<pre>') !== false)
        $forceNewLine = true;

    // Since here, stop adding new line characters
    if(mb_strpos($line, '</pre>') !== false)
        $forceNewLine = false;

    $minified .= $line;

    if($forceNewLine)
        $minified .= "\r\n";

}

$html = $minified;

I would prefer using the package dedicated option, is there a way to fix it in your code ?

Please add .gitattributes file for installing this library via composer with --prefer-dist option. Folder "tests" should be with export-ignore.

Unfortunately, it seems that whitespaces around tags within text contents are removed.

HTML-Code (plain):

<p>
    <strong>Keywords</strong> are really important!
</p>

HTML-Code (minimized)

<p><strong>Keywords</strong>are really important!</p>

Result:

Keywordsare really important!

Used code:

$minimized = HTMLMinify::minify($html, [
    'doctype' => HTMLMinify::DOCTYPE_HTML5,
    'optimizationLevel' => HTMLMinify::OPTIMIZATION_ADVANCED
]);