z0al / dep Goto Github PK

The red cross tells people something failed, but actually it's just waiting. Make this more like WIP, which is a yellow waiting dot for WIP PRs. The effect is the same: can't be submitted, but the message is better.

We're running the bot across our org (not self hosted) and recently it's stopped working and we're not sure why. We've got fairly lengthy PR descriptions but adding "depends on #xx" at the start or end doesn't make a difference, nor does capitalisation or the other key words. We've tried a couple of reinstalls, the first time this seemed to fix things, the second time it hasn't. Please let me know how we can get more information to debug this if required!

We have thought about self-hosting it, but wanted to report here first to see if it was a bug, in which case a self hosted instance might not make a difference.

probot/probot.github.io#303 either you need to provide a fix or be okay with contributors section there. it's failing because your images are returning 404.

I encounter it way more often that issue depend and/or block each other instead of pull requests. Moreover, several projects I'm involved in have started to manually maintain such "depend", "blocked" issue labels, so I would totally love it if the functionality of this bot is getting extended to support issues as well.

Every now and then the Dep app has the following status:

Expected — Waiting for status to be reported

Is there a reason for this or is this a bug? This is still the case after a couple of hours and thus blocking PRs.

It would be nice if the regexes could be configured per-repo.
(So that the tool can adapt to the workflow and not the other way around ;))

Examples of commonly used variants in our repo:

Blocked by: #xxx
Merge after: #yyy
Depends on: #zzz

Currently the bot only recognizes the /depends command in a PR comment. It would be nice if the bot would also recognize the command within the PR description.

It would be awesome if this would work across repositories. That's actually the reason we looked into this bot.

Currently it is possible to create a PR and mark it to have a dependency on itself.

For example when I create the PR #5 and then add a comment to this PR /depends on #5 then dep-bot changes the commit status with the message "Blocked by #5".

I think it is crash behind the scene, just not resolving the DEP status check.
please see here:
Raffaello/sdl2-vga-terminal#90

it might be changed again as i am plannig other commits, but it should be resolved or green or red as there is really nothing to wait for.

Hey @ahmed-taj, this app looks really awesome! Would you be interested in having this listed on probot.github.io? Here are the directions for submitting it to the site if you're interested.

Hi, #234 is a open issue but still the PR status is coming as Success instead of Pending. (when dependency is not resolved). Could you please check If something is missing ?. I tried with both open pull request and issues. In Both the cases. the Pr status is not coming as Pending.

Hey @ahmed-taj,

We just installed the app for our org and one thing we noticed is that the bot only matches on #PR_NUMBER. If I got it right, I tracked it down to this regex:

https://github.com/ahmed-taj/dep/blob/999cc9bf74059404321d8323403c7ffac38f9a05/lib/helpers/match.js#L1

Would you be open to expanding that to support full links to PRs / issues?

Lets say I have the PR #123 and I add two comments to this PR

• first comment /depends on #121
• second comment /depends on #122

then the commit status only includes the dependency of the latest comment, i.e. "Blocked by #122".
I would expect to have the status "Blocked by #121 and #122".

This app checks PRs & issues that are referenced and decides based on the status.
However, in certain cases it is ok to merge it in and would be great to be able to flag it as ok.

Example - Issue is linked but not closed yet because it needs this PR:

DEP is blocking this as it detects this as depending on it given it's still open.

If a pull request has a base that is the branch of a dependency pull request, then watch for that dependency to be merged, and update the dependent's base branch to be the branch that the dependency pull request was merged into.

This would effectively allow for pull request chaining, mentioned at isaacs/github#867. Because the dependent pull request would be made as if it were to the dependency, the diff will be clean.

Because pull requests can only have a base on the same repository / fork as the pull request is on, this inherently requires that pull request chains be all on the same repository (except for the leaf, though that's small consolation).

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The engines config in 1 of your package.json files was updated to the new Node.js version

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Just installed this bot but I'm afraid it's not working. Not sure how to proceed. Might this have to do with deployment?

The dependency status of a PR is not updated when the comment with the original command is edited or deleted.

For example, when I write the command /depends on #123 then the status is updated to "blocked by #123". When I realize that I’ve made a typo and I edit the comment so it says /depends on #124 then the status is not updated to "blocked by #124".

The same is true for deleting the comment with the command. I would expect the dependency to be removed.

Without a green status posted on every PR, we can't make DEP a required check.

It would be nice if we could simply write the following anywhere in a comment: Depends on #something, #something, and #something and it would work. Writing a slash command in a comment feels weird.

I've discovered that DEP currently doesn't act on PRs receiving new commits, which leads to the status being not reported on the most current commit (the one used by github to compute the overall status). That's unfortunate as it prevents me from adding it to the list of required status.

It would be awesome to add DEP to the list of required PR status so that no one can accidentally merge a PR that is awaiting dependencies (eg. because it's based on an other PRs Branch).