Comments (29)
@arichorn The OLED works as expected for me, but indeed the OLD darktheme looks really broken I will look at this tomorrow.
from ytliteplus.
Also here’s this too, I forgot to mention the other issue with OLED but it can be found here arichornlover/uYouEnhanced#48
from ytliteplus.
@arichorn I fixed it but could you test it as I didn't had the Video Player Overflow Menu issue you talk about with OLED darkmode.
https://github.com/Balackburn/YTLitePlus/releases/download/v18.25.1-2.2/YTLitePlus_18.25.1_2.2.ipa
from ytliteplus.
for me everything seem to work correctly
from ytliteplus.
Oh alright thanks! Hope I helped!
from ytliteplus.
Hello! I have reopened the issue because the OLED Dark Theme surprisingly overlaps the whole entire Live Chat View and I believe UIView
is probably the cause?
from ytliteplus.
@arichorn Yes I don't know how to fix it
from ytliteplus.
I do, I can do a pull request. I’ve been working on the new versions of old dark theme and OLED dark theme.
from ytliteplus.
@arichorn Please do a PR
from ytliteplus.
Just did 😉
Haven’t tested the new themes yet though
from ytliteplus.
@arichorn merged it but it don't work can't build it :
https://github.com/Balackburn/YTLitePlus/actions/runs/5699299390/job/15448062448
==> Compiling Source/Themes.xm (arm64)…
Source/Themes.xm:128:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTRelatedVideosCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:130:22: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
} else if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTFullscreenMetadataHighlightsCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:145:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTWatchNextResultsViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:146:14: error: property 'subviews' cannot be found in forward class object 'YTAsyncCollectionView'
self.subviews[0].subviews[0].backgroundColor = customColor;
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:291:58: error: property 'backgroundColor' cannot be found in forward class object 'YTTopAlignedView'
MSHookIvar<YTTopAlignedView *>(self, "_contentView").backgroundColor = customColor;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Source/Themes.xm:39:596: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:550:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTRelatedVideosCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:552:22: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
} else if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTFullscreenMetadataHighlightsCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:567:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTWatchNextResultsViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:568:14: error: property 'subviews' cannot be found in forward class object 'YTAsyncCollectionView'
self.subviews[0].subviews[0].backgroundColor = [UIColor blackColor];
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:713:58: error: property 'backgroundColor' cannot be found in forward class object 'YTTopAlignedView'
MSHookIvar<YTTopAlignedView *>(self, "_contentView").backgroundColor = [UIColor blackColor];
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Source/Themes.xm:39:596: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
10 errors generated.
from ytliteplus.
You are missing some headers. Copy the code from here https://github.com/arichorn/YTLitePlus/blob/main/Header.h
and then replace all of the code in your Header.h
from ytliteplus.
@arichorn thx
from ytliteplus.
No problem!
from ytliteplus.
@arichorn it didn't resolve the issue ( Live Chat View is still hidden) and also why did you changed some element color to blue?
from ytliteplus.
@arichorn I reverted the commits
from ytliteplus.
Oh okay, and the reason why I made it blue is because I tried to make the app look a little different so everything doesn’t have to be white
from ytliteplus.
Also why did you undo the commits was there a reason for that?
from ytliteplus.
@arichorn because I didn't liked the blue element and the issue it was supposed to solve wasn't.
from ytliteplus.
@arichorn because I didn't liked the blue element and the issue it was supposed to solve wasn't.
the blue elements were removable, the blue elements were technically an A/B flag made by Google but just now I have removed the Flag so it’s now white.
from ytliteplus.
@arichorn ah ok sorry for removing it, I will add it back later
from ytliteplus.
@arichorn could you tell me how to disable the blue text from this file :
https://github.com/arichorn/YTLitePlus/blob/12f2e067ff97396220facd3c93a0fa2a52bad31d/Source/Themes.xm
from ytliteplus.
Remove
%hook YTSearchSuggestionCollectionViewCell
- (void)updateColors {
}
%end
And those can be found in Line 384
& 806
and also remove if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; }
because this is the one that’s causing the Live Chats to not show text.
from ytliteplus.
I’m working on a new and polished version of Themes.xm.
https://github.com/arichorn/uYouPlusExtra/blob/main/Source/Themes.xm
don’t use this new one that is shown in the url yet because I’m not finished with this and I’m trying to make it work without using UIView.
from ytliteplus.
@arichorn after removing if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; }
the comment view look like this (even non live comment)
from ytliteplus.
after removing if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; }
the comment view look like this (even non live comment)
That’s not the issue. The reason why it’s doing that is because I accidentally used the wrong color in the _ASDisplayView Hook when modifying the OLED Theme 😅 I apologize about that
from ytliteplus.
@arichorn can't see where it is in the code
from ytliteplus.
I decided to do a pull request so it will be faster.
from ytliteplus.
#23 It's been solved ;)
from ytliteplus.
Related Issues (20)
- [Bug] Error: Process completed with exit code 2, youtube v19.22.3 HOT 14
- [Bug] YouTube's main videos screen breaks when refreshing. HOT 12
- [Bug] App crashes when clicking on a video HOT 1
- [Bug] Crash on new install HOT 4
- [Bug] VP9 cause crash in short HOT 1
- error compiling exit code 2 HOT 7
- [Bug] Downloaded videos can’t be opened in file browser or saved to album
- VP9 Crashing issue fixed in uYouEnhanced maybe can use same fix
- [Bug] Banner ads are shown when "Remove ads" is enabled. HOT 2
- [Bug] Ads shown before video HOT 13
- [Bug] Replace this with your title HOT 1
- [Bug] chromecast not found HOT 3
- [Bug] Playlist only has one page
- v19.24.2-4.0.1 crashes at launch HOT 9
- [Bug] Download & Video Problem HOT 7
- [Bug] YouTube v19.24.2 Crashes When Loading A Video HOT 10
- Can't access You page
- [Bug] Navigation and Tab Bar Missing Certain Icons HOT 3
- [Question] Why before-package?
- [Bug] Icons not showing throughout the UI HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ytliteplus.