Giter Club home page Giter Club logo

Comments (29)

Balackburn avatar Balackburn commented on August 22, 2024 1

@arichorn The OLED works as expected for me, but indeed the OLD darktheme looks really broken I will look at this tomorrow.

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Also here’s this too, I forgot to mention the other issue with OLED but it can be found here arichornlover/uYouEnhanced#48

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn I fixed it but could you test it as I didn't had the Video Player Overflow Menu issue you talk about with OLED darkmode.

https://github.com/Balackburn/YTLitePlus/releases/download/v18.25.1-2.2/YTLitePlus_18.25.1_2.2.ipa

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

for me everything seem to work correctly

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Oh alright thanks! Hope I helped!

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Hello! I have reopened the issue because the OLED Dark Theme surprisingly overlaps the whole entire Live Chat View and I believe UIView is probably the cause?
IMG_2265

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn Yes I don't know how to fix it

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

I do, I can do a pull request. I’ve been working on the new versions of old dark theme and OLED dark theme.

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn Please do a PR

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Just did 😉
Haven’t tested the new themes yet though

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn merged it but it don't work can't build it :
https://github.com/Balackburn/YTLitePlus/actions/runs/5699299390/job/15448062448

==> Compiling Source/Themes.xm (arm64)…
Source/Themes.xm:128:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTRelatedVideosCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:130:22: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
} else if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTFullscreenMetadataHighlightsCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:145:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTWatchNextResultsViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:146:14: error: property 'subviews' cannot be found in forward class object 'YTAsyncCollectionView'
self.subviews[0].subviews[0].backgroundColor = customColor;
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:291:58: error: property 'backgroundColor' cannot be found in forward class object 'YTTopAlignedView'
MSHookIvar<YTTopAlignedView *>(self, "_contentView").backgroundColor = customColor;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Source/Themes.xm:39:596: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:550:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTRelatedVideosCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:552:22: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
} else if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTFullscreenMetadataHighlightsCollectionViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:567:15: error: property 'nextResponder' cannot be found in forward class object 'YTAsyncCollectionView'
if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTWatchNextResultsViewController")]) {
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:568:14: error: property 'subviews' cannot be found in forward class object 'YTAsyncCollectionView'
self.subviews[0].subviews[0].backgroundColor = [UIColor blackColor];
~~~~ ^
Source/Themes.xm:39:899: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
Source/Themes.xm:713:58: error: property 'backgroundColor' cannot be found in forward class object 'YTTopAlignedView'
MSHookIvar<YTTopAlignedView *>(self, "_contentView").backgroundColor = [UIColor blackColor];
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
Source/Themes.xm:39:596: note: forward declaration of class here
@Class YTCollectionView; @Class YTShareTitleView; @Class UIKBRenderConfig; @Class YTShareBusyView; @Class YTSearchSuggestionCollectionViewCell; @Class YTChannelListSubMenuAvatarView; @Class UICandidateViewController; @Class YCHLiveChatActionPanelView; @Class YTVideoView; @Class YTReelShelfCell; @Class YTSearchBarView; @Class YTNavigationBar; @Class YTSubheaderContainerView; @Class YTCinematicContainerView; @Class _ASDisplayView; @Class UIKeyboardLayoutStar; @Class ASScrollView; @Class YTCommentView; @Class YTEmojiTextView; @Class YTWrapperSplitView; @Class YTActionSheetHeaderView; @Class YTTopAlignedView; @Class YTHorizontalCardListView; @Class YTEngagementPanelHeaderView; @Class YTShareMainView; @Class YTChannelSubMenuView; @Class YCHLiveChatView; @Class YTChannelMobileHeaderView; @Class YTTabTitlesView; @Class YTWatchView; @Class SponsorBlockViewController; @Class YTPageView; @Class YTAsyncCollectionView; @Class YTInlineSignInView; @Class YTSearchView; @Class YTAppView; @Class YTCreateCommentTextView; @Class YTOfflineStorageUsageView; @Class YTSlideForActionsView; @Class YTELMView; @Class UIPredictionViewController; @Class YTPivotBarView; @Class YTPlaylistPanelControlsView; @Class YTPlaylistMiniBarView; @Class YTReelShelfItemView; @Class YTCreateCommentAccessoryView; @Class YTReelShelfView; @Class ELMView; @Class YTHeaderView; @Class YTChannelListSubMenuView; @Class GOODialogView; @Class SponsorBlockSettingsController; @Class YCHLiveChatBannerCell; @Class YTPrivacyTosFooterView; @Class YTWatchMiniBarView; @Class YTFeedChannelFilterHeaderView; @Class UIKeyboardDockView; @Class YTSearchBoxView; @Class YTDialogContainerScrollView; @Class YTCommonColorPalette; @Class UIView;
^
10 errors generated.

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

You are missing some headers. Copy the code from here https://github.com/arichorn/YTLitePlus/blob/main/Header.h
and then replace all of the code in your Header.h

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn thx

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

No problem!

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn it didn't resolve the issue ( Live Chat View is still hidden) and also why did you changed some element color to blue?

IMG_2771
IMG_2772

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn I reverted the commits

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Oh okay, and the reason why I made it blue is because I tried to make the app look a little different so everything doesn’t have to be white

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Also why did you undo the commits was there a reason for that?

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn because I didn't liked the blue element and the issue it was supposed to solve wasn't.

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

@arichorn because I didn't liked the blue element and the issue it was supposed to solve wasn't.

the blue elements were removable, the blue elements were technically an A/B flag made by Google but just now I have removed the Flag so it’s now white.

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn ah ok sorry for removing it, I will add it back later

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn could you tell me how to disable the blue text from this file :
https://github.com/arichorn/YTLitePlus/blob/12f2e067ff97396220facd3c93a0fa2a52bad31d/Source/Themes.xm

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

Remove

%hook YTSearchSuggestionCollectionViewCell
- (void)updateColors {
}
%end

And those can be found in Line 384 & 806

and also remove if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; } because this is the one that’s causing the Live Chats to not show text.

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

I’m working on a new and polished version of Themes.xm.
https://github.com/arichorn/uYouPlusExtra/blob/main/Source/Themes.xm
don’t use this new one that is shown in the url yet because I’m not finished with this and I’m trying to make it work without using UIView.

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn after removing if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; }
the comment view look like this (even non live comment)

IMG_2775

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

after removing if ([self.nextResponder isKindOfClass:NSClassFromString(@"YTInnerTubeCollectionViewController")]) { color = customColor; }
the comment view look like this (even non live comment)

That’s not the issue. The reason why it’s doing that is because I accidentally used the wrong color in the _ASDisplayView Hook when modifying the OLED Theme 😅 I apologize about that

from ytliteplus.

Balackburn avatar Balackburn commented on August 22, 2024

@arichorn can't see where it is in the code

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

I decided to do a pull request so it will be faster.

from ytliteplus.

arichornlover avatar arichornlover commented on August 22, 2024

#23 It's been solved ;)

from ytliteplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.