youngcut / kirby-form-block-suite Goto Github PK

After testing some things with a custom formfield and deleting the field .yml file in "site/theme/blueprints/blocks/formfields/", a hidden/special file (.DS_Store) was created in the folder by the OS.

This file is read by
foreach (Dir::read($formblockfolder, [], true) as $f) {
in
mergeFormfields() inside FormBlueprint.php
and throws an empty array error.

Adding a custom ignore:
foreach (Dir::read($formblockfolder, ['.DS_Store'], true) as $f) {
removes the error.

I'm not sure if this is specific to my local dev setup (macOS + MAMP) and how the Kirby Dir::read regular ignore are supposed to work (['.', '..']). Maybe this error should be directed at Kirby. Let me know what you think.

Thank you.

MacOS 12.6.9
Chrome 120.0.6099.109
MAMP 6.6
PHP 8.0.8

When trying to use this plugin with PHP 8.2.0 with MAMP, the entire website will throw an error:

Using ${var} in strings is deprecated, use {$var} instead

The Whoops error handlers identifies this line as throwing the error: https://github.com/youngcut/kirby-form-block-suite/blob/main/classes/FormBlueprint.php#L121

Switching back to PHP 8.1.x is a functional workaround for now.

Firstly, a great plugin thank you.

I really need a way to add 2 recipients to the form. Is this possible or relatively easy for you to add?

I have 4/5 different form blocks across a range of pages and when I make a mailview on site.yml in a new tab it shows the page name but the form labels are all Formular despite having given them distinctive names.

Welcome!

Could you fix the email field to be able to handle email or variables?
In the case of a confirmation email, I receive the email from a variable.
I know it can be solved in code, but please fix it, it would be useful in the long run if you don't have to pay attention to this when updating.
Thank you so much for your attention and participation.

When I have a series of fields and try to view the responses in a mailview and click the i icon the dialog popup default presentation is a little rough as you can see and I cant actually see the data that’s users have submit.

Any ideas on how best to address this?

Hi Youngcut!

I started a new website in the Hungarian language.
I set in the config this:
'microman.formblock' => [ 'default_language' => 'hu' ],
and my user language is Hungarian too.

This is what I saw:

I tried with de and en languages and it worked.

How do I change the default 'from email address?

Currently, emails sent from the forms come from '[email protected]' - the www. part needs to be removed.

Also can the 'reply to address' and 'sent from address' be changed per form?

Hi, and thanks for the plugin!

There is an incompatabilty with afbora/kirby-minify-html.

To reproduce, I added the latest versions of both plugins to the starter kit

• https://github.com/getkirby/starterkit/releases/tag/3.9.2
• https://github.com/afbora/kirby-minify-html/releases/tag/2.0.0
• https://github.com/youngcut/kirby-form-block-suite/releases/tag/v3.4.5

After adding a form to the home page, and clicking send without any fields filled out, you get both a 404 error and a parse error.

The reason for the error is that the kirby-minify-html plugin removes comments. After some experimentation, I found out that the kirby-minify-html plugin does not remove conditional comments (with the <!--[if IE]> syntax), so a fix would perhaps be to change the comments syntax?

I tried that with success, and only two files need to be slightly changed:

• https://github.com/youngcut/kirby-form-block-suite/blob/main/index.php
• https://github.com/youngcut/kirby-form-block-suite/blob/main/snippets/blocks/formcore/validation.php

The changes I did are here:

• rantonse@80a25fc

Basically, these are the changes to the validation.php file:

• Changing <!-- Startvalidation:<?= $form->id() ?> --> to <!--[Startvalidation:<?= $form->id() ?>]-->.
• Changing <?php ?> to <!--[<?php ?>]-->.
• Changing <!-- Endvalidation --> to <!--[Endvalidation]-->.

Then, in index.php, changing the regexp

• from /\<\!-- Startvalidation:'.get('id').' --\>(.*?)\<\!-- Endvalidation --\>/s
• to /\<\!--\[Startvalidation:' . get('id') . '\]--\>\s\<\!--\[(.*?)\]--\>\s\<\!--\[Endvalidation\]--\>/s.

Do you see any downsides to this change?

My default and only language is not English. When I add other languages, translations are working fine, but when I am adding translations for default and only language, here is what I see:

Kirby 3.9.2
If I set the default_language in the config, the site breaks

'microman.formblock' => [
  'default_language' = 'de'
]

Is it possible to turn off the inbox? I don't want to store the messages

Undefined constant "microman\DS"
\site\plugins\kirby-form-block-suite-main\classes\FormBlueprint.php:135

Kirby 4.0.0-rc.4
PHP 8.1.23

I've installed the latest version of Form Block Suite (3.5.7) in a K4 test site and the 'on success' page redirect does not appear to be working.

I've installed from scratch and recreated my form from scratch. In the Options, I've turned on 'Redirect visitor' and selected the relevant page as the destination...

However, when I submit through the form, which is successful and appears in the Panel, the front-end page simply refreshes with the form now gone. I assume it's behaving as if the redirect is not switched on and the page is trying to show a confirmation message, which I haven't entered.

I have upgraded from the old Form Block App, but my forms are still reloading on submit. Did I miss anything when updating from the old plugin?

I replace the plugin folder.
I am still using my previous form.php file is this ok.

Also all my enquiries now just say 'en' in the drawers inbox section. Previously they used to show the users name and email.

Hi!

In v3 version used data-validation attr.
Why remove that?
Plan to put it back?

Hi!

When I wanted to send a form, I got this:

Kirby 4.0.0 and your plugin is up to date.
So now it is not working, please help.

You can check on here:
http://patakimartina.iavel.hu/kapcsolat

Originally posted by @cselex in #28 (comment)

[v3.5.7]

Even when there are new form submissions, the summary highlight built into the form block is grey, rather than green, and shows no numbers in the brackets. In this screenshot, I have two new submissions, but you'd only know that by opening the side drawer. There is no in-page indication.

I am getting “Translation for 'display' not found" instead of {{name}} ({{email}}) in the Inbox.

To reproduce the error, I installed

• https://github.com/getkirby/starterkit/releases/tag/3.9.2
• https://github.com/youngcut/kirby-form-block-suite/releases/tag/v3.4.5

then added a form and submitted it.

Hi!
I find this after I get an error message on the form.

I checked the code but I don't see anything.
You can check here:
http://patakimartina.iavel.hu/kapcsolat

Hey!

As of now the aria-labelledby (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-labelledby) attribute is not added to the fields.

I implemented the proof of concept like this:

Add the attribute to the field:

snippets/blocks/formfields/input.php:

<input
    ...
    aria-labelledby="<?= "label" . $formfield->id() ?>"
    <?= $formfield->autofill(true) ?>
    <?= $formfield->required('attr') ?>
    <?= $formfield->ariaAttr() ?>
/>

And then add the id to the label:

snippets/blocks/formtemplates/fields.php:

<label id="<?= "label" . $field->id() ?>" ...>

To fully support it should be added to the hidden field as well which could be achieved by using the function:

$form->honeypotId()

The clean implementation would probably be in the ariaAttr() function in the FormField class.

What do you think? How would you like it to be implemented? I would be open to contribute by creating a pr 😄

In Kirby 4.1 the plugin cannot be installed with composer, because the composer.json still contains 4.0 as a dependency

I have 3.2 beta installed but the plugins panel in the System screen still has the old plugin name and a '?' for version number.

Hi, just tried the plugin in the kirby starterkit theme. Blueprint and panel workin fine but how do i get it to front?

so custom events can be triggered

kirby()->trigger('formblock.success:after', [
   'request' => $this->request,
]);

Prev issue: #36

You are welcome,
Has there been an incident in the past that this is the answer to?
Look, I use the plugin so that if the customer wants to set up an automatic reply message, he can do so with a few clicks without any extra coding. In this form, the response block in the plugin makes no sense.
Please remove the block or have a solution so that a variable can also be used.
I opened a new ticket because my problem was not solved.

My forms are all working on root-level pages. However, when I put a new form on a child page, the form doesn't validate. I get the 'contact the administrator' message.

Hi,

I receive the error 'Block error: "Call to a member function isFilled() on null" in block type: "form"' when I'm trying to render the form.
Any Ideas what I am missing here?

My template looks like this:
<?= $page->contentblocks()->toBlocks() ?>

Thanks

[v3.5.7]

I have the default {{ name }} ({{ email }}) field identifiers set...

...but they are not displaying in the submission list...

...even though those fields have been populated (they are mandatory).

I am getting 3 mails both for owner and the one who filled the form. Thought maybe it's because of number of translations for plugin, as I had 3, but then checked with 4 translations, still the same - getting 3 mails on every submit.

I implemented the plugin on localhost where it works. But once deployed I see the following issues:

Failed to load resource: the server responded with a status of 400.

The plugin is trying to call https://.../form/validator but that doesn’t seem to exist.

After that, I also get this error but I guess that’s related to the missing result of /form/validator

Inside formblock.js line 80:

TypeError: undefined is not an object (evaluating 'field_data.forEach')

Kirby 4.1.0

What am I missing?

No matter if I enter a random number or leave the field empty, I always get a filesize error: "should not be bigger than -9.5367431640625E-7MB"

Not strictly an issue but definitely a potential feature. I’d like to be able to update the submit button value “Send” and for it to be form specific rather than global.

I’m exploring using this on a site but there are multiple different form types and while I can configured the label in the config file that wont allow me to tailor this to each individual form and page. Would be nice if this possible on the Options tab in the panel potentially.

Is there a way to do this that I’ve perhaps missed?

Hello,
I have a question. I have set-up a basic form using all the default settings. I rendered the blocks on the front-end. But when I test using the form I get this message: 'Uploading 100%'. No errors are given. I get no confirmation text in the front-end and I get nothing in the inbox that confirms somebody used the form. Also no confirmation e-mail is sent to the address in the form (in the screenshot I used a non-existing address but I also tested with my own working email address).

The only thing I edited from the default are a few settings in the panel about send confirmations and confirmation mails (see screenshot below):

I'm working on a local host with the latest Kirby version. (I have not bought the licenses for Kirby and Kirby-form-block-suite yet).
What am I doing wrong here?

Thanks in advance for any help!

Kind regards,

Eric