younesaassila / eslint-plugin-curly-quotes Goto Github PK

Thoughts?

Thanks for creating this plugin!

I have a suggestion for avoiding warnings: typically we might use straight quotes in strings which are used as JSX properties (eg. className) or as arguments to certain functions (eg. Error), which we don't expect to be converted to curly quotes. I know we can use just disable the rule individually, but I believe making this configurable would be much more developer friendly.

Would you accept a PR to allow configuring JSX attributes/function names to avoid traversing?

If a string contains both single and double quotes and if the replacing curly single quote character has a length greater than 1, some double quotes might not get replaced due to textEnd not being accurate anymore because fixedText would have a length greater than the length of text.

Fixable by replacing textStart and textEnd by some variable textTrim that would ignore a certain amount of characters on both sides of the string (since string delimiters go in pair).

We want to allow replacing characters with a length greater than 1 because some quotation marks require spacing to be grammatically correct (e.g. guillemets in French)

In ESLint v9, the old eslintrc config format is deprecated and not enabled by default. Plugins need to migrate to the new flat configuration format. They have provided a guide for how to do so.

For this plugin, I think all that needs to change is to add a meta key to the main entrypoint. Also, it would be helpful to export TypeScript type definitions by adding a types field to package.json.