yocmen / html-minify Goto Github PK

Hello!
This is nice and useful Laravel package, but there's one missing thing.

You should create environment support. For example, in config file add attribute 'production'. If it's set to true, then minify HTML only on production environment.

When using package on local environment, it is a bit jumpy, because I can't debug if something is wrong, etc. When I want to deploy my app on environment server, sometimes I even forget to re-enable this functionality in config, so it causes slower app load.

html-minify collapses white spaces in many places, I don't see the patern, but the regexp that is behind has to be faulty.
To recreate the bug I would suggest to copy the html code from some big web pages, minify it and then compare the resulting minified HTML interpreted by a browser with the original one.

Can you please add option in config to prevent comment stripping?

Needed for:

<!-- googleoff: index -->
Non-SEO text here
<!-- googleon: index -->

I've just installed the package, once I refreshed my view it threw the following error:

(1/1) FatalThrowableErrorCall to undefined method Yocmen\HtmlMinify\HtmlMinifyCompiler::setRawTags()
--
in HtmlMinifyCompiler.php line 21

....

I get this error:

FatalThrowableError in HtmlMinifyCompiler.php line 21:
Call to undefined method Yocmen\HtmlMinify\HtmlMinifyCompiler::setRawTags()

However, if I comment these line:

$this->setRawTags(
    $this->_config['blade']['rawTags'][0],
    $this->_config['blade']['rawTags'][1]
);
$this->setContentTags(
    $this->_config['blade']['contentTags'][0],
    $this->_config['blade']['contentTags'][1]
);

$this->setEscapedContentTags(
    $this->_config['blade']['escapedContentTags'][0],
    $this->_config['blade']['escapedContentTags'][1]
);

It works. Any idea?

I'm using Laravel 5.4.

Hello,
I tried this package with 2 laravel 5 projects and somehow its not working with either of them.
Is there any way to debug?

Regards