yoav-zibin / gamebuilder Goto Github PK

In the latest update and as discussed in the class, GameBuilder does not display images for boards and pieces to save bandwidth. It was harder to create specs this way. User experience could be improved if we could show all the images again. One solution is to cache images. Professor also discussed another solution where we will save lower resolution images in firebase specifically for this purpose.

In some places, we are calling firebase for queries even before determining whether the user is logged in or not. Use auth's onAuthStateChanged event to determine whether the user is logged in (check if (user)), and then only start calling firebase.

Currently GameBuilder only allows to upload images one at a time. Some games have quite a lot pieces and thus its very time consuming to upload dozens of pieces one by one. Adding feature to select multiple images and upload them with a single click would greatly improve user experience.

Hi,
I wanted to modified the games I created before.
Unfortunately it didn't allow me to do that.
Then I tried an alternative way to solve the problem by creating a new game.
But the GameBuilder is not working.

With the amount of data that is there in the firebase DB, I am currently making changes to restrict the images shown only to my uploads. Bring back rest of the dropdown menu filters like standard toggleable etc. by implementing lazy loading. This will require implementing pagination with firebase.

It is very easy to mess up the spec when manually editing the spec. As, we have the test spec feature, we should remove manually edit spec section.

This is a direct solution for #25. Currently, everything is loaded in one go (all of the images, all of the board images, elements are loaded at componentDidMount for some elements). This is not ideal as the data is huge. Fetch only what is needed and on demand not before. This will help in showing images also as there won't be memory bloats.

For example: The steps for creating games with toggleable pieces, and these toggleable pieces should be part of piecesDeck:

1. Upload image for each piece.
2. Create an element(toggleable) using these images.
3. Create another element(piecesDeck) using the above created toggleable elements.

As user is performing same action again and again, user experience can be improved if above steps can be combined in some way. (Don't have any solution in my mind yet)

At lot of places there is code which doesn't have usage anywhere. Preferably use chrome devtools Memory screenshots to find these left over hanging JS heap variables. This will help in recovering some memory and fix memory issues.

Instead of get an image data from all images sections and loading all of that in memory, instead uses Promise.all to get image data for each element.

This has to be majorly refactored in case when we fetch user uploads for elements. We need to remove all of the dependencies on all images and use only necessary stuff.

As a game designer
I would like to submit a game spec
But an issue within the GameBuilder is preventing me from uploading my spec.

Steps to reproduce:

1. Create a new spec
2. Select game board "roulette_board.001"
3. Place elements "roulette-wheel" onto spec, as well as 10 * the following elements:

• roulette-chip-100
• roulette-chip-50
• roulette-chip-25
• roulette-chip-10
• roulette-chip-5
• roulette-chip-1

4. set the wikipedia link to https://en.wikipedia.org/wiki/Roulette
5. set the game icon to roulette_wheel.024
6. set the spec title to "roulette"
7. try to submit.

What is supposed to happen
The spec should be successfully loaded into firebase

What actually happens
The UI presents with a simple error message, "unable to load spec"
Looking into console logs, it is a permission denied error - usually the result of some part of the request not adhering to one of the firebase rules.