ynqa / j9 Goto Github PK

Distributions that provide jq typically also offer development packages that can be discovered by using pkg-config. Adding optional pkg-config configuration to j9-sys would be a welcome step towards easier packaging of jnv without having to build a vendored libjq version.

Description:
I am experiencing an issue when attempting to compile the j9-sys v0.1.2 crate. The custom build command fails with the following error message:

error: failed to run custom build command for `j9-sys v0.1.2`
Caused by:
  process didn't exit successfully: `/tmp/cargo-installsCL7B6/release/build/j9-sys-acd45b9a421ac1f9/build-script-build` (exit status: 101)
  --- stderr
  autoreconf: 1: exec: autoreconf: not found
  ...

Actual Result:
The build process fails, with an error indicating that autoreconf is not installed on the system.

Environment Information:

• Operating System: Ubuntu 22.04
• Rust version: rustc 1.76.0 (07dca489a 2024-02-04)
• Cargo version: 1.76.0 (c84b36747 2024-01-18)

Feedback:
It seems that the build script for j9-sys depends on autoreconf, which is not always present on all platforms. This leads to compilation failure on systems where autoreconf is not pre-installed.

Suggestions:
I recommend adding a check in the build script to verify the presence of autoreconf and to provide clear instructions or automated steps for users to install it if it's missing. Furthermore, it would be beneficial if the crate's documentation included a note about the requirement of autoreconf and how users can address this dependency.

Thank you for considering this feedback. I believe that improved environment checks and prompts will greatly enhance the user experience when working with the j9-sys crate.

When j9::run encounters an error in the input it should result in an error, but it currently fails silently.

Example:

let s = j9::run(".a=(.a|fromjson)", "{\"a\":\"4v2\"}").expect("Should have failed at parsing");
panic!("incorrectly returned success : {s:?}");

prints

incorrectly returned success : []

but

jq -n '{a:"4v2"}' | jq '.a=(.a|fromjson)'

prints

jq: error (at :3): Invalid numeric literal at EOF at line 1, column 3 (while parsing '4v2')