ymyke / cardio Goto Github PK

I think currently some of the effects (fire?) don't work.

Empty is a candidate skill for "A card with Empty will not provide any fire or spirits. This also means the card cannot be sacrificed."

There are at least to basic philosophies to implement such skills:

a) A card with Empty keeps all its stats (esp. has_*) and the code does special handling to check for cards with this skill wherever appropriate (e.g., card placement).

• Could be implemented using properties for all card attributes that take care of taking into account such cases.
• A card always shows its currently relevant states.

b) A card keeps its original stats and adjusts its stats as it gets (and loses, in which case the original stats will be restored) a skill such as Empty.

• That way, the code does not need to identify and handle special cases.
• But it needs to update the states.

b1) Use the state introduced by FightCard for this.

• Simple, already implemented.
• Could use a skill hook that gets called when a FightCard gets created.
• If skills such as Empty play a role in non-fight locations, we'd still need to use the FightCard for that.
• How would cards get displayed inside and outside of fights? In their "Card" or in their "FightCard" state?
• One way to resolve the questions here could be to consider skills "fightskills" that are only applicable in fights and therefore always should the cards in their FightCard state. (If there are other locations, can always do an additional check to see if a skill exists on the card or not.)
• Advantage: We can show the card both in its unskilled and in its skilled state (and offer both views to the user with a keystroke). With option a, this is not possible.

b2) Introduce a new state for this.

• Too complex!

Conclusion

Preference for a ATM.

Cardio uses asciimatics to renter the UI. Asciimatics has an issue with certain emojis. See here:

peterbrittain/asciimatics#368

Thus, certain emojis cannot be used in Cardio because they will be rendered too small. That is the reason why Cardio uses 🏅 instead of ✌️ or 🔰 instead of 🛡️.

• For prepare and attack methods in FightCard
• Tests that directly test the more complex classes such as Shield and LuckyStrike rather than only via fights, as is the default approach in test_skills

• Make fights more compelling.
• Make computer strategy smarter?
• Especially: Fights become predictable/repetitive once cards become powerful enough to defeat opposing agent in one strike. → Just accept this? Prevent cards from getting so strong? Make it much harder for them to become so strong? Have agents grow their health as well? ...?

Check out performance of animations: Esp. when running on battery power. -> Add some setting that helps speed up / slow down the animations. Then do some self-timing e.g. on burning a card that will automatically adjust that setting if necessary (i.e., animation takes too long or too short).

Is this an asciimatics issue? Or what is causing this? Is it the same in different environments (powershell, WSL, Linx, ...)?

Add titles to locations.

Currently, the cards there don't show information around fire and spirits.

fight round vs turn – make terminology consistent in code, strings, documentation

At least add some more cards in later rounds as the game progresses.

cf #106

• TODO: High priority todos
• FIXME: Todos in general.
• QQ: Questions, low-prio todos, etc.

Look for these to see what needs to be done.

Make terminology consistent in code, documentation, strings, DOMAIN etc.

Current usage:

• agent = either computer or human
• player = synonym for agent
• human/computer = one specific agent/player

• Open on Github
• Reddit
• ...?

Maybe move things around / into new foldes