Cannot undo a change made from y-crdt in Yjs about yjs HOT 7 CLOSED

Usually, remote changes are not tracked by Y.UndoManager.

But if you configured it to track remote changes:
Is this issue really specific to Y-CRDT as a remote client?

from yjs.

How can I configure it to track remote changes?

from yjs.

I saw the undo manager ignoreRemoteMapChanges: true option, but it doesn't have any effect.
Basically this is what I am trying to do:

const Y = require('yjs')

const doc0 = new Y.Doc()
const doc1 = new Y.Doc()

doc0.on('update', update => {
  Y.applyUpdate(doc1, update)
})

doc1.on('update', update => {
  Y.applyUpdate(doc0, update)
})

const map0 = doc0.getMap('map')
const map1 = doc1.getMap('map')

const undoManager = new Y.UndoManager(map1)

map0.set('key0', 'val0')
console.log(map1.toJSON())

undoManager.undo()
console.log(map1.toJSON())

Which works fine, because it prints:

{ key0: 'val0' }
{}

The undo manager did undo the remote change.
So it seems that the issue is specific to y-crdt as a remote client.

from yjs.

I don't think so. If you use y-websocket, you need to add the y-websocket provider instance as a tracked origin. Then it should work fine.

Yjs & Y-CRDT should always generate the same updates. Since this is a basic case, I don't expect that they generate different updates that would result in an issue.

from yjs.

If you use y-websocket, you need to add the y-websocket provider instance as a tracked origin.

Thanks, that worked. But is it documented somewhere?

from yjs.

https://docs.yjs.dev/api/undo-manager

Optionally, you may specify trackedOrigins to filter specific changes. By default, all local changes will be tracked.

I updated it to:

Optionally, you may specify trackedOrigins to track changes from different sources. By default, all local changes that don't specify an origin will be tracked.

Feel free to contribute to the docs. I think it already explains how origins can be used.

from yjs.

That part was fine, but I think there should be a mention that y-websocket adds the WebSocket provider as an origin to the changes (that was the information I was missing).

from yjs.