Undo manager without origin doesn't catch updates with origin about yjs HOT 7 OPEN

This would be a breaking change. I also don't agree that an empty list should catch everything.

There could be an option to catch everything. However, I'd like to understand the use case first and if there are alternative solutions (there probably are)

from yjs.

I also don't agree that an empty list should catch everything.

Why? The documentation says that "the changes can be optionally scoped to transaction origins". Doesn't it mean that by not specifying a transaction origin, the scope should include all origins?

My use case is simple: I want to revert a document to a previous state in time (say t0). So at t0 I create an undo manager for a shared type of this document. Somewhere, changes are made to the document with a specified origin (that I'm not aware of). Then I decide to revert the document to the state at t0. But currently the undo manager says that there is nothing to undo.

from yjs.

The thing is that there are currently users of Yjs who specify an empty list and add origins dynamically. If I changed the behavior so that "empty" catches everything, then this would be a breaking change.

There is still the option to have a special flag to catch everything or to set the list to null. An empty list for catching everything is out of the question as it would be a breaking change.

from yjs.

There is still the option to have a special flag to catch everything or to set the list to null.

Sure, that would be an option.

from yjs.

Hi @dmonad, do you think this could be implemented?

from yjs.

Friendly ping @dmonad 😄

from yjs.

Hey David, sorry I can't give an estimate on when I have time to implement this feature.
I'm currently flooded with other things. This ticket takes a low priority for me because it is not relevant for the majority of users.

from yjs.