yitzchok / luach Goto Github PK

I'm attaching a few patches to enhance the About dialog:

* Add an OK button to close (translation not working though)
* Move About to a new Help menu (where it is found in most programs)
* fix several typos in the English text

I'm running QT Luach 0.081, compiled for Ubuntu Lucid, on Debian 6.0.4.  Thank 
you for writing this and releasing it as open source.  I haven't played much 
with the various Jewish calendar applications for Linux, but this one seems to 
do a fine job of showing me when holidays fall.

One request:  In the "Settings > Change location" dialog box, please specify 
whether you want us to enter "Elevation" in feet or meters.  United States 
residents often measure distances in feet.

Building 0.04 with the included ZmanimCLI.jar, I got erroneous zmanim for 
MinchaGedola/MinchaKtana/PlagHamincha in my location.  I managed to get 
around that with some hacking to use the latest upstream ZmanimAPI instead, 
so updating ZmanimAPI within Luach would be helpful.

I'm attaching a patch which adds the standard OK/Cancel icons to the buttons 
in the Change Location dialog.  These icons will be set according to the 
QStyle in use.

I'm attaching a patch which adds a File -> Today action, which changes the 
selected date back to today.

A few build-generated files are in SVN trunk which should not be under 
version control:

Makefile
ui_*.h

The word {E,e}levation is misspelled {E,e}lavation throughout Luach.  This is 
most visible in the ChangeLocation dialog, but also affects locationconf.

What steps will reproduce the problem?
1. added the ppa 
2. apt-get install luach
3. luach ---> it crashes

here is the back-trace as seen at gdb:

Starting program: /usr/bin/luach 
[Thread debugging using libthread_db enabled]

Program received signal SIGSEGV, Segmentation fault.
0x00b26914 in QByteArray::QByteArray(char const*) ()
   from /usr/lib/libQtCore.so.4
(gdb) bt
#0  0x00b26914 in QByteArray::QByteArray(char const*) ()
   from /usr/lib/libQtCore.so.4
#1  0x002581bb in QApplication::palette(QWidget const*) ()
   from /usr/lib/libQtGui.so.4
#2  0x002a659f in QWidgetPrivate::naturalWidgetPalette(unsigned int) const ()
   from /usr/lib/libQtGui.so.4
#3  0x002acb2a in QWidget::setPalette(QPalette const&) ()
   from /usr/lib/libQtGui.so.4
#4  0x0806046e in ?? ()
#5  0x0805ba95 in ?? ()
#6  0x08050cf5 in ?? ()
#7  0x00e6cb56 in __libc_start_main () from /lib/tls/i686/cmov/libc.so.6
#8  0x080508a1 in ?? ()

I'm attaching a patch to improve portability of 'make install'.

Please...

Assaf