Giter Club home page Giter Club logo

Comments (6)

cebe avatar cebe commented on May 24, 2024

created the package and updated composer.json

this package is not a yii extension so it should not be added to yii2-dev.

from yii2-coding-standards.

schmunk42 avatar schmunk42 commented on May 24, 2024

I thought it would make sense, because if you develop Yii 2 you want this package to check your code before you commit.

from yii2-coding-standards.

cebe avatar cebe commented on May 24, 2024

every package included in yii2-dev repo is considered a yii extension for composer package type so we should only put extensions in there.

from yii2-coding-standards.

schmunk42 avatar schmunk42 commented on May 24, 2024

OK, I just thought yii2-dev was short for development. Is there any other use case why you would install yii2-dev besides development?

If you have the package, you can easily check the style with

./vendor/bin/phpcs \
  --extensions=php \
  --standard=vendor/yiisoft/yii2-coding-standards/Yii2/ \
  ./vendor/schmunk42/packaii

edit PS: it such a minimal overhead, with a huge gain.

from yii2-coding-standards.

cebe avatar cebe commented on May 24, 2024

I think it is better to add the code style as dependency yourself if you need it. We are trying to keep unnecessary dependencies out of the packages to minimize download time. we could add it as a suggested package so people know about it.

from yii2-coding-standards.

schmunk42 avatar schmunk42 commented on May 24, 2024

Yes, as a suggest would be nice.

Von meinem iPhone gesendet

Am 07.02.2014 um 14:54 schrieb Carsten Brandt [email protected]:

I think it is better to add the code style as dependency yourself if you need it. We are trying to keep unnecessary dependencies out of the packages to minimize download time. we could add it as a suggested package so people know about it.


Reply to this email directly or view it on GitHub.

from yii2-coding-standards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.