Giter Club home page Giter Club logo

Comments (11)

krukru avatar krukru commented on May 25, 2024 1

I have an open PR #32 that addresses this issue.
For now (until the code gets migrated) I think it would be best to clamp the version in composer.json to "squizlabs/php_codesniffer": ">=2.3.1 <3.0"

from yii2-coding-standards.

davidmpaz avatar davidmpaz commented on May 25, 2024

What is the status of this? Is the PR merged?

from yii2-coding-standards.

samdark avatar samdark commented on May 25, 2024

No. It is not. The version is fixed so codesniffer can't update to v3.

from yii2-coding-standards.

davidmpaz avatar davidmpaz commented on May 25, 2024

Got it. Thanks

from yii2-coding-standards.

biaoqianwo avatar biaoqianwo commented on May 25, 2024

I hope Official to upgrade to support PHPCodeSniffer v3 too.

from yii2-coding-standards.

urosgruber avatar urosgruber commented on May 25, 2024

Can this get merged or project is not maintained anymore?

from yii2-coding-standards.

samdark avatar samdark commented on May 25, 2024

@urosgruber the pull request is w/ issues so wasn't merged. Do you want to fix it and test it properly? Then we'll merge.

from yii2-coding-standards.

urosgruber avatar urosgruber commented on May 25, 2024

I was asking because we're looking to use Codeclimate integration. It's still only for v2 mostly because of plugins not being upgraded to v3. Also I'm on Symfony so I would spend to much time properly fixing this plugin and testing it as I'm not familiar with yii framework.

from yii2-coding-standards.

samdark avatar samdark commented on May 25, 2024

Well, can't merge a solution with known issues.

from yii2-coding-standards.

urosgruber avatar urosgruber commented on May 25, 2024

I understand. Just needed confirmation about the status of this so we know how to proceed

from yii2-coding-standards.

samdark avatar samdark commented on May 25, 2024

#37

from yii2-coding-standards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.