yiisoft / rate-limiter Goto Github PK

Since counter ID is required, it could be moved to method argument i.e.

interface RateLimiter
{
    public function hit(string $id): SomeStats;
}

What steps will reproduce the problem?

http=>https

What is the expected result?

What do you get instead?

Additional info

Use bc.yml from yiisoft/package-template

Should we replace \Yiisoft\Yii\RateLimiter\Time\TimerInterface with the one from https://www.php-fig.org/psr/psr-20?

When concurrent requests are made, flow restriction cannot be applied.
for example,When using caching such as Apcu or Redis, it relies on "TheoreticalNextIncrementTime",It may be dirty reading.

The counter ID should be set. -> The counter ID must be set.

Since ID is required.

State in readme about the fact that by default limiter doesn't work by-user and show examples on how to choose ID correctly.

In description, did you mean 'number of subsequent requests', rather than 'consequently'?

But then I may be misreading the intentioned functionality.

Interesting to see this kind of functionality being clearly exposed for implementation.
Mike B

What steps will reproduce the problem?

http=>https

What is the expected result?

What do you get instead?

Additional info

What steps will reproduce the problem?

What is the expected result?

What do you get instead?

Additional info