Giter Club home page Giter Club logo

ygev / sketch-accessibility-assistant Goto Github PK

View Code? Open in Web Editor NEW
26.0 26.0 3.0 914 KB

Accessibility assistant for all your basic needs. Serves as a linter for compliant color contrast and type based on WCAG 2.1. Thanks to Ale Muñoz for his support and docs!

License: MIT License

JavaScript 3.02% TypeScript 96.98%
a11y a11y-testing accessibility accessibility-assistant accessibility-testing color-contrast color-contrast-checker font-size sketch sketch-app sketch-assistant sketch-assistants sketch-files

sketch-accessibility-assistant's Introduction

Welcome to My GitHub
have fun & try not to break anything

sketch-accessibility-assistant's People

Contributors

bomberstudios avatar dependabot[bot] avatar ygev avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

bomberstudios mcritz ramgexm

sketch-accessibility-assistant's Issues

AA Color Contrast rule fails if an element in a folder is ignored

If I ignore any element that sits in a folder (in this instance, a photo) the rule fails to work.

Error message:

report@
n@
@
generatorResume@[native code]
@
Promise@[native code]
@
@
generatorResume@[native code]
@
Promise@[native code]
ue@
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]
@[native code]
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]

Text letter spacing and line-height rules misunderstood

Thanks for the accessibility assistant, I wanted to take it for a spin as soon as I saw it!

Success Criterion 1.4.12 Text Spacing does not require that all text is set to be 0.12 * font-size letter spacing, but instead it requires that if an end user overrides your website settings to be 0.12 * font size, the interface should not hide content or overlap another content.

https://www.w3.org/WAI/WCAG21/Understanding/text-spacing.html

This is not something that can be checked in sketch as it does not "lay out" the interface automatically. And as such I consider this assistant to report accessibility wrong regarding this.

I'd remove this rule from this assistant as it does not check the WCAG success criterion 1.4.12 correctly.

Edit: I also noticed that the line-height rule has the same misunderstanding. It does not require you to have a line-height of ≥1.5, but requires you to have space for the end user to override your chosen line-height with at least 1.5 and not overlap other text on page. Same problem and recommendation regarding this rule in my mind.

Rule has failed to work: Rule attempted to report an ignored object in a violation 

Rule sketch-accessibility-assistant/sketch-accessibility-assistant/aa-contrast-text produced an error: Rule attempted to report an ignored object in a violation @
report@
n@
@
generatorResume@[native code]
@
Promise@[native code]
@
@
generatorResume@[native code]
@
Promise@[native code]
ue@
@
asyncFunctionResume@[native code]
@[native code]
promiseReactionJobWithoutPromise@[native code]

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.