yetzt / node-rgbcolor Goto Github PK

Line 164 throws and error because key is undefined

color_string = simple_colors[key] || color_string;

but shouldn't it be

color_string = simple_colors[color_string] || color_string;

It looks like unrolling the program (removing both of the loops) doubles its speed based on a crude perf test implementing code coverage, but that little line change that I proposed (which logically made sense) in a previous issue didn't do a thing (JIT inline optimized). Whoops.

http://jsperf.com/stoyan-s-rgbcolor-js

Input needs to be tested that it's a string or it'll throw errors.

Hi there, thanks for making this library! I wanted to check -- should this library handle SVG colors? Right now, it returns false for this value:

var RGBColor = require("rgbcolor");
const color = new RGBColor("rgb(100%,100%,100%)");
if (!color.ok) {
	throw new Error("Did not recognize this input")
       // => throws error
}

For processing CSS it would be great if parsing alpha values was supported. I could contribute to this, however I am not sure what would be the best, backwards-compatible way to support this? Maybe just introduce this.alpha = 1.0, and add toRGBA() method?