yantrashala / loopback-component-logger Goto Github PK

using the "enableAPI" flag to true raise this error before boot is completed,
do you think will be possible to have some indication to proceed with a PR

process.nextTick(function() { throw err; });
^

Error: loopback.getCurrentContext() was removed in version 3.0. See http://loopback.io/doc/en/lb2/Using-current-context.html for more details.
at Function.juggler.getCurrentContext.remoting.getCurrentContext.loopback.getCurrentContext [as getCurrentContext] (

server/server.js has the following code app.emit('started', baseUrl); if emitted multiple times gives a duplicate Logger error.

The code in loopbackHook.js

     var enableAPI = config.enableAPI || false;
     if(enableAPI) {
         // adding log management api
         loggerModel.addModel(app);
         app.on('started', function(){
             loggerModel.attachLoggerMap(loggerMap);
         });
     }

app.on can be changed to app.once to prevent loggerModel.addMode(app) to be executed multiple times

Need to remove the console.log from the npm package from loggerModel.js in line no 56.

console.log('Updating level for logger with name',
                        ctx.instance.name, ', New level is',ctx.instance.level);
            loggerMap[ctx.instance.name].level(ctx.instance.level);

I tried to add loopback-component-logger to a loopback api project.

• First I installed:

npm install --save loopback-component-logger bunyan

• Then I added to my server.js

var bunyan = require('bunyan');
var rootLogger = bunyan.createLogger({name: 'myAPI', level: 'info'});
var logger = require('loopback-component-logger')(rootLogger);

• Finally added this to component-config.json

,
  "loopback-component-logger": {
      "enableAPI" : true
  }

And I get the error pointed on execution

• Versions I'm using

node v6.1.0
npm 3.7.5
loopback 2.22.0
bunyan 1.8.1
loopback-component-logger 0.3.2

• When I comment server.js logger definition lines I get this output

WARN: Logger not initialized correctly  using defaultLogger
Updating level for logger with name perfLogger , New level is 30

I can see how defaultLogger is loaded correctly so I supose the problem must be on the Logger definition I'm using