Giter Club home page Giter Club logo

Comments (4)

GeneralWadaling avatar GeneralWadaling commented on May 10, 2024

Further tested with latest 4.10 compared to current 4.11, pretty sure something must have happened with 4.11 update causing this

from unciv.

yairm210 avatar yairm210 commented on May 10, 2024

Thanks for investigating this!
Found the problem - Alpha Frontier uses multi-parameter uniques for placing resources ("Generated on every [28] tiles <in [Featureless] [Tundra] tiles>") which has been deprecated in favor of multifilter ("Generated on every [28] tiles <in [{Featureless} {Tundra}] tiles>")

Checking the mod checker, I can see that these were indeed NOT caught, so that's on us

So the fix is in two places:

  • Alpha Frontier should convert their resource placement uniques
  • We need to ensure that mod checker catches uniques on resources

from unciv.

yairm210 avatar yairm210 commented on May 10, 2024

AHA
This is actually better than I thought - turns out we don't check deprecation of conditionals AT ALL
So that's on us

from unciv.

yairm210 avatar yairm210 commented on May 10, 2024

Our side is solved in 773d996, now Alpha Frontier needs to change their resource uniques

from unciv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.