Giter Club home page Giter Club logo

Comments (5)

SpacedOutChicken avatar SpacedOutChicken commented on May 10, 2024

Here is the mod being used: https://github.com/Dimensiondog/religious-victory-unciv/

The mod checker doesn't detect anything wrong with it.

from unciv.

SeventhM avatar SeventhM commented on May 10, 2024

Not sure if it is a mod issue or my dev environment, but am struggling to reproduce by injecting Religious Victory into Rekmod. Does this crash specifically with your mod or does it crash inside of other mods like Deciv?

Also, does it crash with just the G&K ruleset or does it crash with other mods that don't set the victory types?

from unciv.

SpacedOutChicken avatar SpacedOutChicken commented on May 10, 2024

So far, I only get the crash with the specific "religious victory unciv" mod that adds the victory type to the G&K ruleset. It didn't happen on Windows, but it kept happening on Android. I'll test it out with some other mods.

from unciv.

yairm210 avatar yairm210 commented on May 10, 2024

Due to civinfo settransients calling victorymanager at the end which checks which victory milestones have been achieved.
When religious victory is an option this means checking the religionManager of other civs which have not yet been initialized.

We can either settransients for religionmanager for all civs before civinfo settransients, or defer the victory settransients to after - I'm leaning towards the second option, because who knows if victory manager will have other milestones that depend on other civs

from unciv.

SeventhM avatar SeventhM commented on May 10, 2024

I see. I will also lean towards after for similar reasons

from unciv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.