Here, if we've "filterUrl" as "", ycb doesn't replace it.

e.g
1)
[{"dimensions":[{"environment":{"development":{"dev":null,"test":null},"production":{"int":null,"stage":null,"prod":null}}}]},{"settings":["master"],"name":"highlander_client","config":{"baseUrl":"http://finance.yahoo.com","filterUrl":""},"dataprovider":{"Test YHOO Original 1":{"group":"smoke","params":{"page":"$$config.baseUrl$$$$config.filterUrl$$","test":"test.js"}}}}]

after ycb replacement translates to

{"name":"highlander_client","config":{"baseUrl":"http://finance.yahoo.com","filterUrl":""},"dataprovider":{"Test YHOO Original 1":{"group":"smoke","params":{"page":"$$config.baseUrl$$$$config.filterUrl$$","test":"test.js"}}}}

In case of non-empty values, replacement works good

[{"dimensions":[{"environment":{"development":{"dev":null,"test":null},"production":{"int":null,"stage":null,"prod":null}}}]},{"settings":["master"],"name":"highlander_client","config":{"baseUrl":"http://finance.yahoo.com","filterUrl":"/q?s=YHOO"},"dataprovider":{"Test YHOO Original 1":{"group":"smoke","params":{"page":"$$config.baseUrl$$$$config.filterUrl$$","test":"test.js"}}}}]

after ycb replacement translates to

{"name":"highlander_client","config":{"baseUrl":"http://finance.yahoo.com","filterUrl":"/q?s=YHOO"},"dataprovider":{"Test YHOO Original 1":{"group":"smoke","params":{"page":"http://finance.yahoo.com/q?s=YHOO","test":"test.js"}}}}

For some reason, while debugging a mojito app using node-inspector, I found a weird situation where to was undefined, and to[key] = ... was triggering an error that was silenced. Probably we should add guarding for that to avoid doing extra computations when the destination does not exists.

    function objectMerge(from, to) {
        var key;
        for (key in from) {
            if (from.hasOwnProperty(key)) {
                try {
                    // Property in destination object set; update its value.
                    if (from[key].constructor === Object) {
                        to[key] = objectMerge(from[key], to[key]);
                    } else {
                        to[key] = from[key];
                    }
                } catch(err) {
                    // Property in destination object not set; create it and set its value.
                    to[key] = from[key];
                }
            }
        }
        return to;
    }

I notice that if I add some settings under an dimension value not listed in dimension.json, it overwrites the value in master. I can use this simple example to reproduce:

If I add this:

  {
    "settings": [ "environment:stage" ],
    "appPort": 81
  }

stage is not listed in dimension.json. It overwrites the "appPort": 8666 in master and the test fails. Is it an intended behavior?

1

There is a comma missing between this two items:

{
    settings: ["environment:dev"],
    host: "dev.example.com"
}
{
    settings: ["environment:staging,test"],
    host: "stage.example.com"
},

2

After correcting that, the code breaks with ...

            this._dimensionHierarchies[name] = this._calculateHierarchy(DEFAULT_LOOKUP, this.dimensions[pos][name]);
                                                                                                            ^

TypeError: Cannot read property 'device' of undefined
    at Object.Ycb._calculateHierarchies (/Users/rose119/Sites/ycb-webpacked/node_modules/ycb/index.js:591:109)
    at Object.Ycb._processRawBundle (/Users/rose119/Sites/ycb-webpacked/node_modules/ycb/index.js:437:22)
    at Object.Ycb (/Users/rose119/Sites/ycb-webpacked/node_modules/ycb/index.js:76:10)
    at Object.<anonymous> (/Users/rose119/Sites/ycb-webpacked/index.js:41:14)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:139:18)

Is it possible to improve the README a bit to include the bundle specifications and possibly some examples? I know the tests covers some of the examples, but it would be really nice to cover these in the documentation.

The current "debug" logging in YCB is very much oriented towards the team who is authoring YCB. Instead, users of YCB might benefit from a logging approach which helps them understand how YCB is processing/interpretting their config files.

or is that not implemented?

Its time to get rid of settings: ['master'] in favor of friendlier term for obvious reasons.

Dependabot couldn't reach registry.npm.vzbuilders.com:4443/npm-registry/api/npm/npm-registry as it timed out.

Is registry.npm.vzbuilders.com:4443/npm-registry/api/npm/npm-registry accessible over the internet? If it is then this may be a transitory issue and can be ignored - Dependabot will close it on its next successful update run.

View the update logs.

@proverma

Currently if a string has two ycb params, like
"page" : "$$baseUrl$$/$$path$$"

Only first param gets replaced by ycb, and second param gets left unreplaced.

We often find ourselves copying and pasting blocks of configs such as:

[
    {
        settings: ['region:US'],
        value: 'foo'
    },
    {
        settings: ['region:CA'],
        value: 'foo'
    }
]

It would be convenient to be able to collapse these duplicated sections together like so:

[
    {
        settings: ['region:CA,US'],
        value: 'foo'
    }
]

YCB, as today, is a server side only component, you can corroborate this by looking at index.js, which uses require. By looking at the code, there are only 3 YUI features used by this:

• Y.JSON., which could be replaced with JSON.
• Y.Object.values, to iterate, which could be done by just using in
• Y.Array.forEach, to iterate, which could be done by just using for

Using YUI on the server, in its current form, is expensive, and in this particular case, it looks like a waste.

If two Ycb objects are created with the same data, read calls on the second ycb object always return an empty object, instead of a resolved configuration bundle.

To reproduce, add these lines to the end of https://github.com/yahoo/ycb/blob/master/examples/simple/app.js

var foo = new libycb.Ycb(data, {});
config = foo.read({});
assert.equal(8666, config.appPort);

node examples/simple/app will result in:
AssertionError: 8666 == "undefined" because the output of foo.read({}) is {}