xwmx / hosts Goto Github PK

bryan-mbp:~$ brew tap alphabetum/taps && brew install alphabetum/taps/hosts
==> Tapping alphabetum/taps
Cloning into '/usr/local/Homebrew/Library/Taps/alphabetum/homebrew-taps'...
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (22/22), done.
remote: Total 23 (delta 11), reused 7 (delta 1), pack-reused 0
Unpacking objects: 100% (23/23), done.
Tapped 4 casks and 14 formulae (67 files, 39.7KB).
==> Installing hosts from alphabetum/taps
==> Cloning https://github.com/alphabetum/hosts.git
Cloning into '/Users/btalbot/Library/Caches/Homebrew/hosts--git'...
warning: Could not find remote branch 3.1.1 to clone.
fatal: Remote branch 3.1.1 not found in upstream origin
Error: An exception occurred within a child process:
DownloadError: Failed to download resource "hosts"
Failure while executing; git clone --depth 1 --branch 3.1.1 https://github.com/alphabetum/hosts.git /Users/btalbot/Library/Caches/Homebrew/hosts--git exited with 128. Here's the output:
Cloning into '/Users/btalbot/Library/Caches/Homebrew/hosts--git'...
warning: Could not find remote branch 3.1.1 to clone.
fatal: Remote branch 3.1.1 not found in upstream origin

i tried using hosts to add an entry with the exact command

sudo hosts add 0.0.0.0 hassan.dev

this however doest recognise the hostname provided. i've tried alternative hostname, hostname provided as string but still no luck, it simply returns, no matter what arguments i provide to the add command

Please include a hostname
Usage:
  hosts add <ip> <hostname> [comment]

Description:
  Add a given IP address and hostname pair, along with an optional comment.

Hi @alphabetum great utility! Not an issue, just wanted to give you a heads up.

I created and maintain the package for hosts on the AUR:

https://aur.archlinux.org/packages/hosts/

Arch Linux users can install and upgrade with their package managers now.

When executing hosts remove <hostname> --force the command fails with No matching records found. however if one executes hosts list you can see the entry is still there.

e.g.,

hosts ensure 192.168.0.1 gateway.example.com

If the entry already exists in the hosts file then do nothing, add it otherwise.

When editing, it gives an error - line 1155: EDITOR: variable bounds not set.

The problem was solved in the _verify_write_permissions function by adding the -E argument to sudo in line 367

_verify_write_permissions() {
  if [[ ! -w "${HOSTS_PATH}" ]]
  then
    if ((_AUTO_SUDO))
    then
      local _my_path
      _my_path="$(cd "$(dirname "$0")"; pwd)/${_ME}"

      sudo -E "${_my_path}" "${_SUBCOMMAND}" "${_COMMAND_PARAMETERS[@]:-}"
      exit $?
    else
      _exit_1 printf \
"You don't have permission to perform this operation. Try again with:
sudo !!\\n"
    fi
  fi
}

I have included the script in a project directory where it is called from a project setup shell script.

Because of this line, on/around line 241, the internal recursive calls to itself fail.
_ME=$(basename "${0}")

This may not be the most elegant fix for it, but this works.

_ME=$(cd "$(dirname "$0")"; pwd)/$(basename "${0}")

This is because the script is trying to call itself without a path.

Thanks for (presumably) releasing this under a free licence!

Unfortunately, there's no indication in hosts that it's free software, or that the LICENSE file here applies to it. This is particularly problematic as users are encouraged to copy/curl it as a stand-alone script.

The short text of LICENSE should be included verbatim as a comment in the script itself, under the copyright notice.

This is FQDN entry:

1.2.3.4 server.box.com server

This is not FQDN entry:

1.2.3.4 server.box.com

Consider the following:

hosts add --auto-sudo 127.0.0.1 cdn.cubing.net
sudo -k # clear `sudo`
hosts add --auto-sudo 127.0.0.1 cdn.cubing.net

Since adding a host is idempotent, the second invocation doesn't change the /etc/hosts file, and hosts can tell this without asking for sudo. It would be nice if --auto-sudo was a little smarter and avoided the prompt. (In fact, that was sort of my assumption based on the name.)

Hello,

Firstly, Thank you for saving the time to manage the host file also when I remove an entry that shows message "sed: can't read : No such file or directory".

Sometimes you are testing or waiting for some domain to update its DNS and you add your domain to your hosts but often you forgot to delete that entry. I suggest some syntax as parameters to the add command like this:

hosts add --autoremove --time=30m 10.12.13.14 example.com

This command should schedule a crontab job in 30m to run hosts remove example.com

Here is the command and output:

 bpkg install xwmx/hosts   

    info: Install /xwmx/hosts/master from remote https://raw.githubusercontent.com [https://github.com]
    info: Cloning https://github.com/xwmx/hosts.sh.git to /var/folders/_g/sphjngbn4ms0rxcyys6rt5br0000gn/T/hosts.sh-master

This results in nothing being installed and I cannot figure out why.