xujiajun / gorouter Goto Github PK

see https://github.com/xujiajun/gorouter/releases/tag/v1.2.0 for detail.

If inscribe.

非常棒的项目，简单明了，准备参照你的这个项目实现一个路由器。

Your current benchmark doesn't say which CPU model you're using for the benchmark. This is probably the most important part to include. I assume you're running some pre 7th-gen Intel i5/i7 CPU since it's on a Mac with DDR3 RAM.

Benchmark System:
Go Version : go1.11.2 darwin/amd64
OS: Mac OS X 10.13.6
Architecture: x86_64
RAM; 16 GB 2133 MHz LPDDR3
CPU: ???

比如在assets目录下有不一定的几层目录，现在这样好像处理不了，要一层一层写？

Currently your benchmark code does the following:

func benchRoutes(b *testing.B, router http.Handler, routes []route) {
	b.N = 10000
	b.ReportAllocs()
	b.ResetTimer()

	for i := 0; i < b.N; i++ {
		for _, route := range routes {
			router.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(route.method, route.path, nil))
		}
	}
}

The critical part is the router.ServeHTTP(httptest.NewRecorder(), httptest.NewRequest(route.method, route.path, nil)) within the loop, meaning that you allocate and initialize a new Recorder and a Request in every loop iteration.
Unfortunately that is likely much more expensive than the actual routing, meaning that both the measured memory cost and the execution time are completely meaningless, since there is a huge baseline cost.

user need to add url partern for every depth folder ?
is there a short way to match a total folder as below

// FileSystem custom file system handler
type FileSystem struct {
    fs http.FileSystem
}

// Open opens file
func (fs FileSystem) Open(path string) (http.File, error) {
    f, err := fs.fs.Open(path)
    if err != nil {
        return nil, err
    }

    s, err := f.Stat()
    if s.IsDir() {
        index := strings.TrimSuffix(path, "/") + "/index.html"
        if _, err := fs.fs.Open(index); err != nil {
            return nil, err
        }
    }

    return f, nil
}


fileServer := http.FileServer(FileSystem{http.Dir(".")})
http.Handle("/static/", http.StripPrefix(strings.TrimRight("/static/", "/"), fileServer))

I like the idea of this router, and I'm planning on using it for an upcoming project. However the automatic regex matching for :id and :name is bothering me. I don't want to use it, and if I do, I'll provide my own regex. How do I prevent any regex matching from happening for those parameters?

I don't think it's a good idea to assume the regex that people want to use for random parameters, it can cause bugs and other problems. But that's just my opinion.

Router always return 404 response header
"Hello world!" run the same with error code.

# go version 
go version go1.13.7 linux/amd64

# curl  localhost:8181 
hello world

# curl  localhost:8181 -I 
HTTP/1.1 404 Not Found

已经解决了。。。。。

Your router looks very attractive from a performance perspective.

But it looks like it is missing a very important feature for REST API that is reverse routing.

I am widely using gorilla/mux along with its reverse routing right now and would like to find a faster alternative for it.

If your router would have this feature, it would be very useful.

• Fixed bench_test error
• Add more tests
• Add more routers to compare in bench_test
• Support reverseRouting && add demo and tests
• Refactor router and tree
• Update README.md

see https://github.com/xujiajun/gorouter/releases/tag/v1.1.0 for detail.

Server side code:

func main() {
	mux := gorouter.New()
	//url regex match
	mux.GET("/user/{id:[0-9]+}/", func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte("match user/{id:[0-9]+} !"))
	})

	log.Fatal(http.ListenAndServe(":8181", mux))
}

like url： http://localhost:8080/abc?id=123

how to get the 123

or should I get it from http.request directly ?