xtreamwayz / psr-container-messenger Goto Github PK

Remove the middleware config from the standard configuration as it does not work when adding more middleware. The order can't be specified correctly.

The configuration should be move to example config files which users can copy and adjust.

• require: "php": "^7.3 || ^8.0"
• require-dev: "phpunit/phpunit": "^9.4"

Is your feature request related to a problem? Please describe.
In symfony/messenger at version 4.3 a new middleware called AddBusNameStampMiddleware was added.
You need to add this middleware to your bus to handle async messanges properly.
The middleware needs bus name as constructor dependency.

Describe the solution you'd like
Adding a static factory for the AddBusNameStampMiddleware.

We found a constelation, when using RabbitMQ with the transport option

    'messenger' => [
        'transports' => [
             'options' => ['confirm_timeout' => 1]
        ]
]

no retry is made. So we add a middleware to retry this dispatch. This middleware must be added to the command bus configuration.

<?php

declare(strict_types=1);

namespace Mehrkanal\Messenger\Middleware;

use AMQPQueueException;
use Psr\Log\LoggerInterface;
use RuntimeException;
use Symfony\Component\Messenger\Envelope;
use Symfony\Component\Messenger\Exception\TransportException;
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
use Symfony\Component\Messenger\Middleware\StackInterface;
use Throwable;

final class ConfirmTimeoutMiddleware implements MiddlewareInterface
{
    public const MAX_PUBLISH_TRIES = 5;

    public function __construct(private LoggerInterface $logger)
    {
    }

    public function handle(Envelope $envelope, StackInterface $stack): Envelope
    {
        for ($try = 0; $try < self::MAX_PUBLISH_TRIES; $try++) {
            try {
                return $stack->next()
                    ->handle($envelope, $stack);
            } catch (AMQPQueueException|TransportException $exception) {
                $this->logger->warning(
                    'RabbitMQ publishing retry.',
                    [
                        'class' => self::class,
                        'exception_class' => $exception::class,
                        'exception_message' => $exception->getMessage(),
                        'exception_trace' => $exception->getTrace(),
                        'envelop' => $envelope,
                        'try' => $try,
                    ]
                );
            } catch (Throwable $throwable) {
                $this->logger->critical('RabbitMQ publishing exception.', [
                    'class' => self::class,
                    'envelop' => $envelope,
                    'exception_class' => $throwable::class,
                    'exception_message' => $throwable->getMessage(),
                    'exception_trace' => $throwable->getTrace(),
                ]);
                throw new RuntimeException('Publishing failed', previous: $throwable);
            }
        }
        $this->logger->critical('RabbitMQ publishing failed.', [
            'class' => self::class,
            'envelop' => $envelope,
        ]);
        throw new RuntimeException('Publishing failed');
    }
}

Since this project has no recent activity, and there are no responses to Merge Requests I place my knowlege her. Because we had some trouble with missing Messages.

greetings Thomas

https://symfony.com/blog/new-in-symfony-4-3-messenger-failure-transport

Is your feature request related to a problem? Please describe.
I would like to create a queue with additional config parameters e.g. with argument 'x-queue-type' => 'quorum',.
In the current TransportFactory I can only declare the dsn.

Describe the solution you'd like
I want the possibility to create a transport with a config alias instead of the dsn. The config alias should reference to an config array with a dsn and additional arguments.

Is the intention of this project to move laminas/laminas-service-manager from "required" to "require-dev"?

Either:

• This should be the case, so that other PSR-11 containers can use the provided factories (as I believe would currently be the case).
• Or the third argument provided to __invoke() on the factories: string $requestedName, should be used in place of class names where possible, to allow factories to be reused.

The logging middleware is removed in 4.3. Logging can now be added to the transports and message handling middleware.

Is your feature request related to a problem? Please describe.

I can't select my own event dispatcher.

Describe the solution you'd like

Use the psr/event-dispatcher instead of hardcoding the Symfony dispatcher.

Describe alternatives you've considered

n/a

Additional context

n/a

Describe the bug
If someone uses mezzio + PHP-DI, they will receive an error MessageBusFactory::messenger.command.bus() is not a callable. A __call() or __callStatic() method exists but magic methods are not supported.

PHP-DI uses PHP-DI/Invoker.

To Reproduce
Steps to reproduce the behavior:

1. Create project of Mezzio with PHP-DI container
2. Add current library into the project
3. Try to dispatch a command
4. See error

Version of the xtreamwayz/psr-container-messenger library
2.5.0

Expected behavior
Command successfully dispatched.

How to fix it for yourself
Use custom configuration entries for the factories or custom ConfigProvider

This issue provides visibility into Renovate updates and their statuses. Learn more

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): lock file maintenance

• Check this box to trigger a request for Renovate to run again on this repository