xrpl-labs / path-find-xapp Goto Github PK

Pathfinding is an xApp and should not open in the browser in the first place. Thing to fix here is that the xApp shouldn't allow for opening in the browser where no Xumm user agent is present. I'll add an issue on Github for when Koen is back from a few days off this week

When running the app from e.g. my context, rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ, there are incoming Trust Lines being displayed in the asset list (like WIE). These are TrustLines (and assets) people setup Trust Lines towards me, but there are no tokens sent by me (no obligations). If TrustLines are in default state on "self", they should be suppressed in the list. We added it like this in XUMM as well (for info / code: @N3TC4T)

In my rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ account I have a token with UTF8 encoded name as per common XRPL non-3 char token name use. There's a decoding FN for that, you can copy/paste from here:

https://github.com/XRPL-Labs/XrplTxData/blob/main/src/ext-dependencies/utils.ts#L31

Please change error messages (like this one) to something more professional. Some users do not appreciate this from an application they use to manage their savings 😇

When trying to change the source account, upon slide to sign the change, after closing, the Wild error while trying to log in occurs.

X-currency partial payments between two different issued assets cannot be initiated if the sending account has a zero balance of the currency that should be delivered to the receiving account.

Example:
A1 = Sending Account
A2 = Receiving Account
C1 = Originating Currency (NOT XRP)
C2 = Destination Currency (NOT XRP)

• A1 does not have a C2 balance.
• A1 initiates tx to send C1 and deliver C2 to A2.
• Tx does not execute because A1 does not have enough C2 in it's account.
• C2 "Balance insufficient" error is displayed instead.

A1's C2 balance should be irrelevant. If A1 did have enough C2, then A1 could just send that directly. If A1 does have enough C2 in it's account, then the tx succeeds even though 0 C2 are sent. This error is not observed when C1 is XRP.

This behavior is seen in both the Path Finding xApp and on XRP Toolkit when setting up the tx manually. Is the issue due to these applications, or is the behavior inherent to the XRPL? If this is inherent to the XRPL, shouldn't this be considered a bug?