Comments (17)
Hi,
Thanks for the report. Indeed there is quite some mess in pROC's NAMESPACE file - methods are just exported and I never got around to fix it. Probably because I never managed to get an error with it. Now indeed with requireNamespace("pROC") it is clearly broken.
I created a branch s3_methods_namespace where this should now be fixed. Could you please confirm? This version can be installed for example with:
# install.packages("devtools")
library(devtools)
install_github("xrobin/pROC@s3_methods_namespace")
I will need more testing to make sure some other code (in pROC and the packages that depend on it) isn't broken before it can be released, but I'll do that as soon as possible.
from proc.
Hi + Thx.
I tested it with the branch version, and it seems to be OK.
Please close this when you update on CRAN so I know when to depend on a new version in our DESCRIPTION.
from proc.
Right now this is breaking the package RcmdrPlugin.ROC. I emailed the maintainer and hope he can update it soon.
I will also email the maintainer of the other packages that depend on pROC in the next few days to inform them of the change so they can check their code beforehand.
from proc.
RcmdrPlugin.ROC is fixed but I just discovered an other issue, in the caret package this time. Pull request sent to topepo/caret#125.
from proc.
I've merged your pull request. Thanks for doing that.
I'm working on a release of caret
and want to use the dependency pROC (>= 1.8)
. When do you think that this will be on CRAN?
Thanks,
Max
from proc.
Thanks for merging the pull request.
As soon as the pull request is on CRAN I will try to push the 1.8.
Unfortunately it can't be the other way around, as CRAN would never accept an update breaking caret (or any other package for that matter). One option would be a to submit both updates at the same time.
Please note that the pull request I submitted will work with any version of pROC from 1.0, so there is no need to depend on 1.8.
from proc.
Let's submit at the same time and send them a message beforehand. I've got a few outstanding things to finish before the next version and I think I'll be done in the next two weeks. How does that sound?
from proc.
Ok, let me know a few days before so we can land it. I may probably submit a bit earlier, if I tell the CRAN maintainers that you'll fix caret right after they'll probably accept the new version of pROC.
from proc.
Just discovered an additional error when testing caretEnsemble (zachmayer/caretEnsemble#135). I had mistakenly thought it was related with the issue mentioned earlier in caret.
from proc.
I'm ready for a new CRAN version for caret
. Are you geared up for a pROC
submission? I can email CRAN and explain the situation in the meantime (unless you would rather communicate the issue).
Thanks,
Max
from proc.
Yeah I'm basically ready (I believe I can go ahead despite zachmayer/caretEnsemble#135, that shouldn't be a blocker). Pretty much any time this week would be good (TZ GMT+2).
from proc.
Okay. I'll send CRAN a message saying that your pROC
version 1.8 will break caret
checks but I have a fixed version of caret
that i will send in as soon as pROC
is accepted.
Thanks for your help,
Max
from proc.
v1.8 submitted to CRAN with the note about caret, among others. Hopefully it will go through.
from proc.
I'm sorry the submission was rejected as there is a NOTE in R CMD check that I documented, but apparently the CRAN team missed the comment - at least I hope so.
from proc.
No problem. version 1.8 is on CRAN and I'm getting my stuff together to
submit.
Thanks,
Max
On Tue, May 5, 2015 at 2:10 AM, Xavier Robin [email protected]
wrote:
I'm sorry the submission was rejected as there is a NOTE in R CMD check
that I documented, but apparently the CRAN team missed the comment - at
least I hope so.—
Reply to this email directly or view it on GitHub
#4 (comment).
from proc.
I insisted a bit and they published it.
So I guess that's it, thanks for your patience.
from proc.
The new version of caret is on CRAN now.
Thanks,
Max
On Tue, May 5, 2015 at 9:38 AM, Xavier Robin [email protected]
wrote:
I insisted a bit and they published it.
So I guess that's it, thanks for your patience.
—
Reply to this email directly or view it on GitHub
#4 (comment).
from proc.
Related Issues (20)
- ggroc.list parameter legacy.axes break HOT 2
- One-sided CIs for AUCs HOT 2
- Averaging 10 ROC curves HOT 4
- How to print the threshold without specificity and sensitivity HOT 2
- Cannot create a roc curve with a formula and a with clause HOT 2
- CRAN submission failed with new message Apparent methods for exported generics not registered
- Fix warning: `aes_string()` was deprecated in ggplot2 3.0.0 HOT 1
- Move aes_string() to aes() HOT 1
- Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0. HOT 1
- The `path` argument of `expect_doppelganger()` is deprecated as of vdiffr 1.0.0. HOT 1
- Uncaught warnings in tests HOT 1
- Support for spaces in column names with formula
- A non-monotonic ROC is being produced by ggroc HOT 2
- Obuchowski and McClish (1997) sample size calculation incorrect HOT 6
- Mean ROC curve in ggroc() HOT 5
- pROC, detectable AUC HOT 2
- What does "direction" mean in roc function HOT 3
- Default method parameter in ci.auc function is different from documentation HOT 1
- Example for AUPRC with confidence interval HOT 1
- Incorrect AUC value and CI [bug] HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proc.