xp-framework / rest Goto Github PK

Instead of gathering all results in an array I'd like to be able to return a traversable or an iterator directly and have the API handle that for me; potentially optimizing by starting direct unbuffered writes to the client.

Current situation

The standard way: Fetch results, gather into array, return:

#[@webmethod(verb= 'GET')]
public function all() {
  $q= $this->conn->query('select * from swarm');
  $result= [];
  while ($record= $q->next()) {
    $result[]= $this->asResult($record);
  }
  return $result;
}

New

Together with xp-framework/rdbms#2 and data sequences, we can now write:

#[@webmethod(verb= 'GET')]
public function all() {
  $q= $this->conn->query('select * from swarm');
  return Sequence::of($q)->map([$this, 'asResult']);
}

If I omit the urlencode() call in the code below I get an lang.FormatException ("" is not a valid HTTP response [-1]), which is because an invalid HTTP request is sent.

Code

$response= $client->execute((new RestRequest('/kibana-int/dashboard/{dashboard}', 'GET'))
  ->withSegment('dashboard', urlencode($this->dashBoard))
  ->withAccept('application/json')
);

Request

GET /kibana-int/dashboard/My example dashboard HTTP/1.1
Connection: close
Host: elk.example.com:9200
Accept: application/json

See https://travis-ci.org/xp-framework/rest/jobs/234372333

Compile error (Declaration of io\File▒336::in() must be compatible with io\File::in(): io\streams\InputStream)

This is only inside the tests, the main code works fine with PHP 7.2