Giter Club home page Giter Club logo

ryzenadjctrl's People

Contributors

xodj avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ryzenadjctrl's Issues

Awesome app

Just wanted to say thanks πŸ™ and tested working in AMD Ryzen 7 4800H in Windows 11

git tag versions are outdated: Lower than latest release (0.5.1.870 vs. 0.5.2.926 vs. 0.5.2.929).

  • Latest release version is 0.5.1.870.
  • git describe --tags of a fresh clone of this repository just shows 0.5.1.870-9-gbaf6084, which is lower.
  • Latest entry of git log states a version 0.5.2.929.

Since your PKGBUILD, which is part of this repository, uses git describe --tags to generate the version, you get a lower version than latest release AND lower than latest commit message.

Please fix and make sure git describe --tags stays at least at the latest release version.

Regards!

[patch] Use system provided `ryzenadj.h`.

The following patch to CtrlService.h allows for the use of ryzenadj.h already present on the system when ryzenadj is installed:

diff -U1 -r xodj-RyzenAdjCtrl.org/CtrlService.h xodj-RyzenAdjCtrl/CtrlService.h
--- xodj-RyzenAdjCtrl.org/CtrlService.h	2024-01-29 14:23:08.867198072 +0100
+++ xodj-RyzenAdjCtrl/CtrlService.h	2024-01-29 14:23:57.040533430 +0100
@@ -11,3 +11,3 @@
 #include "CtrlArmour.h"
-#include "lib/ryzenadj.h"
+#include "ryzenadj.h"
 #include "CtrlBus.h"

Regards!

[patch] Fixes for the bundled `PKGBUILD`.

Your bundled PKGBUILD has some issues.

Amongst others:

I post a patch below, and the full version is β†—β€Šhere:

 pkgname="ryzenctrl-git"
-pkgver=0.5.2.926
+epoch=1
+pkgver=0.5.1.870+9.r140.20220301.baf6084
 pkgrel=1
 pkgdesc="Fine-tuning of power limits and frequency of APU Ryzen Mobile"
 url="https://github.com/xodj/RyzenAdjCtrl"
 arch=("x86_64")
-depends=("ryzen_smu-dkms-git" "ryzenadj-git" "qt6-base" "qt6-svg")
-makedepends=("git" "cmake" "qt6-tools")
-optdepends=("faustus-rublag-dkms-git: (AUR) Needed for ArmoryCrate profiles support.")
-license=("GPL3")
-provides=("${pkgname%-git}")
-conflicts=("${pkgname%-git}")
-source=("${pkgname%-git}::git+https://github.com/xodj/RyzenAdjCtrl" "ryzenadj-git::git+https://github.com/FlyGoat/RyzenAdj")
-sha256sums=("SKIP" "SKIP")
-install="ryzenctrl-root.service.install"
+depends=(
+  "gcc-libs"
+  "glibc"
+  "hicolor-icon-theme"
+  "ryzen_smu"
+  "ryzenadj"
+  "qt5-base"
+  # "qt5-svg"
+)
+makedepends=(
+  "binutils"
+  "cmake"
+  "gcc"
+  "git"
+  "make"
+)
+optdepends=(
+  "faustus-rublag-dkms: Needed for ArmoryCrate profiles support."
+)
+license=("GPL-3.0-or-later")
+provides=(
+  "${pkgname%-git}=${pkgver}"
+)
+conflicts=(
+  "${pkgname%-git}"
+)
+source=(
+  "xodj-RyzenAdjCtrl::git+https://github.com/xodj/RyzenAdjCtrl.git"
+  #"ryzenadj::git+https://github.com/FlyGoat/RyzenAdj.git" # Needed for `lib/ryzenadj.h`, and needed to be downloaded to `ryzenadj`.
+  "fix-ryzenadj.h-path.patch"
+)
+sha256sums=(
+  "SKIP"
+  #"SKIP"
+  "95389e1380d8a18ae55b0500916053016ad830f5b942e9f5ca2c8f82d53c061a"
+)
+
+prepare() {
+  cd "${srcdir}/xodj-RyzenAdjCtrl"
+
+  for _patch in "${srcdir}/fix-ryzenadj.h-path.patch"; do
+    printf '%s\n' "    > Applying patch '$(basename "${_patch}")' ..."
+    patch -N -p1 --follow-symlinks -i "${_patch}"
+  done
+
+  mkdir -p build
+
+  git log > git.log
+}
+
 
 pkgver() {
-    cd "$srcdir/${pkgname%-git}"
-    git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
+  cd "${srcdir}/xodj-RyzenAdjCtrl"
+  _ver="$(git describe  --tags | sed 's|^[vV]||' | sed 's|-g[0-9a-fA-F]*$||' | tr '-' '+')"
+  _rev="$(git rev-list --count HEAD)"
+  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
+  _hash="$(git rev-parse --short HEAD)"
+
+  if [ -z "${_ver}" ]; then
+    error "Version could not be determined."
+    return 1
+  else
+    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
+  fi
 }
 
 build() {
-    cd "$srcdir/${pkgname%-git}"
-    mkdir build -p && cd build
-    cmake -DCMAKE_BUILD_TYPE=Release ..
-    make
+  cd "${srcdir}/xodj-RyzenAdjCtrl"
+  cd build
+  cmake \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DCMAKE_INSTALL_PREFIX=/usr \
+    -DBUILD_STANDALONE=false \
+    ..
+  make
 }
 
 package() {
-    cd "$srcdir/${pkgname%-git}"
-    install -Dsm755 ./build/Appfolder/RyzenCtrl $pkgdir/usr/bin/RyzenCtrl
-    install -Dm644 ./ru.ryzenctrl.service.conf $pkgdir/etc/dbus-1/system.d/ru.ryzenctrl.service.conf
-	install -Dm755 ./RyzenCtrl.desktop $pkgdir/usr/share/applications/RyzenCtrl.desktop
-    install -Dm644 ./ryzenctrl-root.service $pkgdir/usr/lib/systemd/system/ryzenctrl-root.service
-	install -Dm644 ./media/main/amd_icon.png $pkgdir/usr/share/icons/hicolor/256x256/apps/amd_icon.png
+  cd "${srcdir}/xodj-RyzenAdjCtrl"
+
+  install -Dsm755 "build/Appfolder/RyzenCtrl"  "${pkgdir}/usr/bin/RyzenCtrl"
+  install -Dvm644 "ru.ryzenctrl.service.conf"  "${pkgdir}/etc/dbus-1/system.d/ru.ryzenctrl.service.conf"
+  install -Dvm755 "RyzenCtrl.desktop"          "${pkgdir}/usr/share/applications/RyzenCtrl.desktop"
+  install -Dvm644 "ryzenctrl-root.service"     "${pkgdir}/usr/lib/systemd/system/ryzenctrl-root.service"
+  install -Dvm644 "media/main/amd_icon.png"    "${pkgdir}/usr/share/icons/hicolor/256x256/apps/amd_icon.png"
+
+  for _docfile in git.log README.md; do
+    install -Dvm644 -t "${pkgdir}/usr/share/doc/${pkgname%-git}" "${_docfile}"
+  done
+  for _licensefile in LICENSE; do
+    install -Dvm644 -t "${pkgdir}/usr/share/licenses/${pkgname}" "${_licensefile}"
+    ln -svr "${pkgdir}/usr/share/licenses/${pkgname}/$(basename "${_licensefile}")" "${pkgdir}/usr/share/doc/${pkgname%-git}/$(basename "${_licensefile}")"
+  done
 }

Regards!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.