Giter Club home page Giter Club logo

om-cookie-manager's People

Contributors

baschte avatar drwh0286 avatar lukasniestroj avatar nhovratov avatar vitd avatar xippo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

om-cookie-manager's Issues

Multidomain setup

On a multidomain website with diverent storage folders all cookie groups are visible in available groups. Change line 164 to

'foreign_table_where' => 'AND tx_omcookiemanager_domain_model_cookiegroup.pid=###CURRENT_PID### AND tx_omcookiemanager_domain_model_cookiegroup.sys_language_uid = ###REC_FIELD_sys_language_uid###',

and only the cookie groups of the current pagetree are visible.

Cookies not deleted on changed preferences

Hey, if I have accepted all cookies and after that I change my mind / my settings some cookies are beeing deleted but the Google Analytics Cookies are still present.

Invalid W3C Markup

<input class="cookie-panel__checkbox {f:if(condition:cookiegroup.essential,then:'cookie-panel__checkbox--state-inactiv',else:'')}" autocomplete="off" data-omcookie-panel-grp="1" id="group-{cookiegroup.uid}" type="checkbox" {f:if(condition:cookiegroup.essential,then:'checked=1 data-omcookie-panel-essential="1" disabled="disabled"',else:'')} value="group-{cookiegroup.uid}" />

This line is not W3C valid. Attribute checked should not be checked="1", only checked instead. Autocomplete does not exist for input type="check". Change to valid input with:

<input class="cookie-panel__checkbox {f:if(condition:cookiegroup.essential,then:'cookie-panel__checkbox--state-inactiv',else:'')}" data-omcookie-panel-grp="1" id="group-{cookiegroup.uid}" type="checkbox" {f:if(condition:cookiegroup.essential,then:'checked data-omcookie-panel-essential="1" disabled="disabled"',else:'')} value="group-{cookiegroup.uid}" />

Add OM-Cookie-Manager Cookie in Cookie Option List

Hi, thanks for your extension!

In the FE options the visitor can see all the cookies delivered by the website. But what about the OM-Cookie-Manager Cookie itself? It will not get listed although it will be fired.

I may could add it to the Cookie records in the backend options without entering html but I wonder if you think it is not needed to list it?

Kind regards

Clear entries in deprecation log file for TYPO3 11

There are many entries in the TYPO3 deprecation log file like:

Calling method TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin with argument $extensionName ("OM.OmCookieManager") containing the vendor name ("OM") is deprecated and will stop working in TYPO3 11.0.

Calling method TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin with argument $extensionName ("OM.OmCookieManager") containing the vendor name ("OM") is deprecated and will stop working in TYPO3 11.0.

Calling method TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule with argument $extensionName containing the vendor name is deprecated and will stop working in TYPO3 11.0.

The 'tx_omcookiemanager_domain_model_cookie' TCA tables transOrigPointerField 'l10n_parent' is defined as excluded field which is no longer needed and should therefore be removed.

The 'tx_omcookiemanager_domain_model_cookie' TCA configuration 'showRecordFieldList' inside the section 'interface' is not evaluated anymore and should therefore be removed.

The TCA field 'sys_language_uid' of table 'tx_omcookiemanager_domain_model_cookie' is defined as the 'languageField' and should therefore use the TCA type 'language' instead of TCA type 'select' with 'foreign_table=sys_language' or 'special=languages'.

Please clean up your TCA / ext_localconf.php / ext_tables.php according to TYPO3 11

Using TS constants in HTML is not possible in TYPO3 10 anymore

Unfortunately the feature to use TS constants in the HTML field to e.g.set different ids on different pages does not work anymore, because the method \TYPO3\CMS\Core\TypoScript\TemplateService::substituteConstants() is not public anymore. So trying this it fails with an error.

A11Y color contrast

Lighthouse accessibility test claims the color contrast of the button with white text on green background is not sufficient. Even with the upcoming more fine grained APAC metric, it's failing contrast requirements.
A solution would be to switch to a darker green.

image

image

Changing default lifetime of 'cookie consent cookie'

It would be a nice feature being able to set the default lifetime of the 'cookie consent' cookie itself - it defaults to 365 days, but if I change cookies or -groups after people already accepted their choice of cookies on a website they wont see the panel anymore from that day on until a year after.

This could be problematic e.g. if I make a cookie which was non-essential an essential cookie some day, it won't be for all 'existing' visitors until their 365 days are passed.

A similar 'workaround' would be the possibility to change the default name of the cookie - but would mean to change the JS file, so probably is not THAT ideal solution.

Keyboard Accessibility

Currently the cookie panel is inserted at the end of the DOM. If you are a screenreader user or a keyboard user you need to tab through all focusable elements of the page to finally get to the cookie panel at the very end. Only then you can make your choice and with that close the panel. Depending on the page it is likely that you need to tab through links/buttons that are visually hidden behind the cookie panel.

There are several ways to improve this, reading https://uxdesign.cc/cookie-banners-and-accessibility-d476bf9ee4fc and watching a screenreader user interacting with cookie panels https://www.youtube.com/watch?v=Uaqo4FOI_DY (especially from min 11), I think the best practice would be to follow the Alert Dialog pattern (https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog/). That is to make the cookie banner the first thing on the page and trap the focus inside of the panel. Only after the user has clicked on a button, the panel is closed and the actual page content is accessible.

Current behavior
image

Expected behavior
image

Revocable?

Hi!
Is there a simple way (i.e. onlick-event) to call the cookiebanner again after closing it?
AFAIK that is a must have due to new TTDSG rules..

Thanks!
Christoph

DEFAULT 0 NOT Null issue with MYSQL 5.5 and TYPO3 8.7 - Incorrect table definition

uid int(11) NOT NULL auto_increment,

Seens so that MYSQL 5.5 couldnt handle the

uid int(11) NOT NULL auto_increment, statement in combination
PRIMARY KEY (uid),

it will result in an "Incorrect table definition; there can be only one auto column and it must be defined as a key" error.

This will fix it and will work also MYSQL Version >5.5

uid int(11) unsigned DEFAULT 0 NOT NULL auto_increment,

Google Consent Mode (Feature Request)

Google Consent Mode Integration (Feature Request)

Hi, it would be nice (essential for comercial use) to have a tracking without consent.
When do you support google consent mode?
Greets from Münster, M.

How about a feature to replace iframe content only after consent to specific group?

Hi, I miss this feature in this extension. I mean replace all kind of external loaded content (iframe,object) with a placholder and only after giving consent to a specific cookie group the content will be loaded.
Is there a chance for realizing? If you think yes, I have an idea and would spend some time on it. But I wont do work for nothing if you don't plan to integrate those feature.

Missing extenison key

Composer beklagt fehlenden Extension Key:
The TYPO3 extension package "opfaff/om-cookie-manager", does not define an extension key in its composer.json. Please report this to the author of this package. Specifying the extension key will be mandatory in future versions of TYPO3 (see: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/ComposerJson/Index.html#extra)

In die composer.json-Datei muss sowas integriert werden:
"extra": {
"typo3/cms": {
"extension-key": "om-cookie-manager"
}
}

Setting add to body doesn´t work

Hi all!
Maybe someone can confirm that:

Changing the setting "Insert in" to "body" the setting is ignored (code still added in the header).

TYPO3 9.5.20
OM Cookie-Manager. 10.0.1

Best,
Christoph

Composer Support

Great Extension, very customizable.
Please support compser req.

Thanks.

Outsourcing of HTML / Script markup to files?

Excuse me in case I have missed it - looked through the manual but could not find anything related: Can I somehow 'outsource' the html markup for cookies to real files and reference those instead of having my JS code stored to the DB in the cookie records? I would love to have them in files for git storage reasons as well as minification..

Error while saving or delete Group or Panel

I get an error while i save, delete or move a group or a panel in TYPO3 backend. This happen because the details_nr field in the database table is declared as smallint (6) and can't hold 10 digits.

Bestimmte Cookies pro Sprache ausblenden geht nicht

Erstmal: Super Extension!
Mein Problem ist folgendes... Auf der Website werden mehrere Sprachen verwendet. Jetzt soll auf der deutschen Seite kein Google Analytics verwendet werden... auf der französischen und der englischen aber schon. Wenn ich die deutsche Übersetzung bei Cookies deaktiviere, dann bekomme ich als Fallback Englisch angezeigt.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.