Comments (3)
This crash should be fixed as of fb1b578.
Also, perhaps this is an adjacent concern, but I will say that it is intentional for all external player libraries to be installed by default. Otherwise we would have to ask users to manually install libraries after changing the config, which I don't want to do.
Thanks for the help!
from castero.
@xgi vlc is quite heavy duty/large and virtually useless to have if you already have mpv. I'm pretty sure making all media players required is neither common, nor needed.
Otherwise we would have to ask users to manually install libraries after changing the config, which I don't want to do.
Could you elaborate? I don't follow. mps-youtube, a python TUI app that supports a wide variety of media players, just tells you "hey, your current media player configuration is not supported, please install the required files (or change your config)". You could easily wrap the python import vlc/mpv
statement in a try
block and inform the user about what needs to be done. Or just go with what the user already has installed if it's found, and error out otherwise. I'm absolutely sure TUI users can handle a simple pip install
recommendation, or install a mediaplayer through their package manager or whatever.
Some background: python-vlc
pulls in a ton of dependencies on my system.
from castero.
@rien333 I created #62 to address this concern, although I don't currently have a clear plan for dealing with it. Thanks!
from castero.
Related Issues (20)
- New feature: status/progress bar HOT 2
- Do not clear queue when manually playing next episode HOT 4
- adding "shut up a second" podcast crashes castero HOT 1
- crashes after press the h key HOT 2
- Handle current episode url with script to enable copy to clipboard HOT 2
- Freeze upon wake from suspend HOT 4
- Request: make default layout configurable HOT 1
- cannot change selection color
- New release request (with width fix) HOT 1
- Support speed increase over 2.0x HOT 1
- Client crashing after adding some feeds
- Episode marked as undone after refreshing the feed
- Custom (per-podcast) start position [Feature Request]
- Option to change metadata display format
- Feature Request: autoplay queue HOT 2
- FeedParseError: Unable to parse text as xml documents HOT 1
- TypeError: argument of type 'NoneType' is not iterable HOT 3
- Future request: ALSA channels volume control
- [Feature Request]: Add MPRIS Support For Linux Users HOT 1
- Using cron to update the feeds periodically
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from castero.