runtime dependency on python-vlc about castero HOT 3 CLOSED

This crash should be fixed as of fb1b578.

Also, perhaps this is an adjacent concern, but I will say that it is intentional for all external player libraries to be installed by default. Otherwise we would have to ask users to manually install libraries after changing the config, which I don't want to do.

Thanks for the help!

from castero.

@xgi vlc is quite heavy duty/large and virtually useless to have if you already have mpv. I'm pretty sure making all media players required is neither common, nor needed.

Otherwise we would have to ask users to manually install libraries after changing the config, which I don't want to do.

Could you elaborate? I don't follow. mps-youtube, a python TUI app that supports a wide variety of media players, just tells you "hey, your current media player configuration is not supported, please install the required files (or change your config)". You could easily wrap the python import vlc/mpv statement in a try block and inform the user about what needs to be done. Or just go with what the user already has installed if it's found, and error out otherwise. I'm absolutely sure TUI users can handle a simple pip install recommendation, or install a mediaplayer through their package manager or whatever.

Some background: python-vlc pulls in a ton of dependencies on my system.

from castero.

@rien333 I created #62 to address this concern, although I don't currently have a clear plan for dealing with it. Thanks!

from castero.