xeboris / polepp Goto Github PK

There seems to be a slight system dependancy on the result. Need to nail this 
down...

On a Linux box I typed 'make', which created 'libpolelib.so'.
Typing 'make tools' as suggested in the README file did not
create any binaries in the bin directory, as I imagine it should.

lfs1> make
make[1]: Entering directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0'
**** src ****
make[2]: Entering directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0/src'
  Compiling Pdf.cxx
  Compiling Coverage.cxx
  Compiling Random.cxx
  Compiling Tools.cxx
  Linking libpolelib.so
make[2]: Leaving directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0/src'
**** tools/polelim ****
make[2]: Entering directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0/tools/polelim'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0/tools/polelim'
make[1]: Leaving directory 
`/lfs/l1/hess/users/deil/bin/HESSSurveyBin/POLEPP-1.0.0'
lfs1> make tools
make: Nothing to be done for `tools'.
lfs1> ls -lh bin/
total 0
lfs1> ls -lh lib/
total 0
-rwxr-xr-x 1 deil hfm 775K 2011-06-23 12:42 libpolelib.so

It would be nice if the documentation of the tools were available from the 
doxygen html page, which explains the statistical method used.

As a newcomer I find it hard to understand what tools are available and what 
they do.
E.g. the doxygen html page lists (but doesn't describe) four tools:
polelim
polecov
polebelt
poleconst

The README explains two tools: polelim, polecov

Actually there are six tools:
$ ls -1 tools
polebelt
polecomb
poleconst
polecov
polelim
polepow

But only polelim and polecov are build by default.

What do the other tools do? Are they only for internal debugging or useful for 
users?

I tried running the polelim example in the README file, which resulted in the 
following error:


$ ./polelim --effdist 0 --bkgdist 2 --bkgmeas 2 --bkgsigma 0.5 --nobs 4
Tools::calcIntRange() -> Unknown pdf type = 999

================ P O L E ==================
 1.0 - conf. level  : 0.1
 N observed         : 4
----------------------------------------------
 Coverage friendly  : No
 True signal        : 1
----------------------------------------------
 Efficiency meas    : 1
 Efficiency sigma   : 0.2
 Efficiency dist    : Undefined
 Efficiency scale   : 1
----------------------------------------------
 Background meas    : 2
 Background sigma   : 0.5
 Background dist    : Gauss
 Background scale   : 1
----------------------------------------------
 Bkg-Eff correlation: 0
----------------------------------------------
 GSL int. N(calls)  : 100
----------------------------------------------
 Int. eff. min      : 0
           max      : 5
----------------------------------------------
 Int. bkg. min      : 0
           max      : 5
----------------------------------------------
 Binary search thr. : 0.0001
 1-CL threshold     : 0.0001
 Min prob in belt   : 0.001
----------------------------------------------
 *Test hyp. min     : 0
 *Test hyp. max     : 35
 *Test hyp. step    : 0.01
----------------------------------------------
 Step mu_best       : 0.01
 Max N, mu_best     : 20
----------------------------------------------
 Method             : FHC2
----------------------------------------------
 Verbosity          : 0
----------------------------------------------
 Parameters prefixed with a * above are not   
 relevant for limit calculations.
==============================================
gsl: vegas.c:128: ERROR: xu must be greater than xl
Default GSL error handler invoked.
Abort trap

For some of the other examples I get slightly different output, in some cases 
because default values have changed, 

For one example I get a slightly different upper limit:
./polelim --nobs 30
result in  [ 17.812500, 47.708691 ]
whereas the README file states [ 17.81, 47.66 ]

I am trying to build polepp on Mac OS 10.6.

--- Issue 1:

make results in the following errors:

**** src ****
  Compiling Pdf.cxx
In file included from Pdf.cxx:2:
Pdf.h: In member function 'const double PDF::Gamma::raw(double, double, double) 
const':
Pdf.h:822: error: 'isinf' was not declared in this scope
Pdf.h:822: error: 'isnan' was not declared in this scope
Pdf.h: In member function 'const double PDF::Poisson::raw(int, double) const':
Pdf.h:866: error: 'isinf' was not declared in this scope
Pdf.h:866: error: 'isnan' was not declared in this scope
Pdf.h:871: error: 'isnan' was not declared in this scope
make[2]: *** [.linux/Pdf.o] Error 1
make[1]: *** [src] Error 2
make: *** [all] Error 2

The problem is that isinf and isnan are in namespace std, writing std::isinf 
and std::isnan everywhere solves this problem.

--- Issue 2:

GSL is installed on my system in /opt/local/include and /opt/local/lib.
At the moment I get the following error:

**** src ****
  Compiling Coverage.cxx
In file included from Pole.h:52,
                 from Coverage.h:19,
                 from Coverage.cxx:13:
Integrator.h:8:26: error: gsl/gsl_math.h: No such file or directory
...

How can I include that info in the Makefile?
Can you add this info to the install instructions?

--- Issue 3:

make doc fails with the following error:

  Doxygenating
warning: Tag `MAX_DOT_GRAPH_WIDTH' at line 146 of file Doxyfile has become 
obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_HEIGHT' at line 147 of file Doxyfile has become 
obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
error: tag OUTPUT_DIRECTORY: Output directory 
`/afs/cern.ch/user/t/tegen/www/statistics/PoleLibDoxy' does not exist and 
cannot be created
Exiting...
make: *** [doc] Error 1

Removing the hardcoded directory fixes the problem, i.e. change line 8 of 
Doxyfile to
OUTPUT_DIRECTORY       = 
and the doc will be built in doxy-html.

I'm looking forward to using the tools once I manage to build them. :-)