xando / commitcoffee Goto Github PK

Slight UX issue - when you search on an iPhone, the keyboard remains present, blocking most of the map.

One possible fix would be to take the focus away from the input box after a search (to hide the keyboard) however still listen for keypresses then redirect the input to the search field. However, that's not particularly clean.

Anyone have any thoughts or ideas on how we could improve this?

@jqb @NotBobTheBuilder

I've added AUTHORS.md file, your names are there but feel free to modify as you like adding handles twitter, email, www, anything else.

https://github.com/xando/commitcoffee/blob/gh-pages/AUTHORS.md

Sorry for being off topic but this had to be said

Would be cool to have links to sites such as twitter, facebook etc showing up next to the Café's name if they're a part of the link object.

I don't mind working on this - I'll submit a pull request shortly.

I think this repo could benefit from having Travis run integration tests on pull requests.

Even something which just validates places.js would be useful.

It would be awesome to have an alternative to the search box which uses window.navigator.geolocation to search for nearby places based on lat/longitude.

Would be particularly useful for mobile users, as it saves typing & gives relevant info. I'll look into it!

Cool idea. One suggestion: if you store the locations as GeoJSON rather than a purpose-built JSON schema you'll get a few advantages:

1. GitHub will natively render the GeoJSON. Here's an example of bars in DC with WIFI. You could consume the GeoJSON directly into Leaflet (open source FTW) or even use the embed endpoint to embed the map directly, alleviating the need for complex client-side logic. (Raw GeoJSON)
2. Rather than having to manually edit and geocode the JSON file, you could use something like geojson.io, so that people could edit the list directly in their browser
3. It'd be an open format that could be natively consumed elsewhere.

Dear Sebastian,

If you have time and interest, would you kindly consider an alternative approach to this project's implementation:

• Use OpenStreetMap as the base layer for the map
• Add coffee places to OpenStreetMap for them to appear on the map

This approach might be a bit more complex than the current one. However, it is clearly aimed at geeks, and geeks are not easily scared of complexity :)

This website serves as a good starting point for OpenStreetMap:

http://www.switch2osm.com

Thank you.

Looks like the site has to update for the new GitHub Pages system. This is an email I just got (I think we all did)

The page build failed with the following error:

The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must take immediate corrective action to ensure that your site remains available after December 1st, 2014. Additional details can be found at https://github.com/blog/1917-github-pages-legacy-ip-deprecation. For more information, see https://help.github.com/articles/setting-up-a-custom-domain-with-github-pages.

If you have any questions please contact us at https://github.com/contact.

$ python validate.py give me:

WARNING: 'coordinates' of place: 'Kukania' should be a list of exactly two elements, but instead: ''
WARNING: 'coordinates' of place: 'Starbucks Coffee' should be a list of exactly two elements, but instead: ''
WARNING: 'coordinates' of place: 'Tarabuk' should be a list of exactly two elements, but instead: ''
WARNING: 'coordinates' of place: 'W Biegu Cafe' should be a list of exactly two elements, but instead: ''
WARNING: 'coordinates' of place: 'CoffeInn' should be a list of exactly two elements, but instead: ''

@xando: xando.json, line 248, 300, 332, 347, 422,

and tokki.json, the only entry