Currently Xamarin.MSBuild.Sdk GenerateSolution is using the old project system Guid for C#:

When generating .sln for SDK-Style projects it should be using 9A19103F-16F7-4668-BE54-9A1E7A4F7556 instead.

When writing out the .sln it should attempt to preserve the order of SlnSections as it found them in the original file.

Non Issue, but I'm guessing the comment below meant to say "Simple and efficient immutable list..."

/// Simple inefficient immutable list backed by List for the sake

from

Right now when a project is not included in a solution configuration, it's property set in the project configuration doesn't include either ActiveCfg or Build.0 - it's missing entirely.

Unfortunately this messes with Visual Studio 2017 for Windows :( VS Win insists on having ActiveCfg for all configurations, but to avoid building a project in a configuration it wants to omit the Build.0 entry.

Is it worth it folding MSBuildLocator.cs into the official MSBuildLocator project/package?

Consider adding Condition="Exists('$(MSBuildExtensionsPath)\Xamarin\Mac\Xamarin.Mac.Common.targets')" so that NuGet can restore packages even if the file doesn't exist. Maybe make it a warning instead.

Instead of Condition="$(_CanOutputAppBundle)" I think it should say Condition="$(_CanOutputAppBundle) != 'false'" or == 'true' depending on which way the default is.

I've seen MSBuild complain today that condition `` was expected to be true or false, but I can't remember where I saw it.

1. Use Xamarin.Mac.Sdk/0.17.0.
2. Reference (directly or indirectly) System.Memory or System.Threading.Tasks.Extensions in your app.
3. Build and run.

Expected results

Correct assemblies are bundled; app runs without issue.

Actual results

Reference assemblies from the nupkg are bundled; app may crash if these assemblies ever need to be loaded and used.

I have created a sample at https://github.com/sandyarmstrong/WitnessMe. See its README for details on reproducing, and where my investigations have taken me so far.

Hi,

I came across the Xamarin.MSBuild.Sdk package while searching for a better way to manage complex project structures and it has been working great so far. However, I would like to be able to re-use my *.proj file to generate multiple solutions (our framework has multiple target platforms with their own dependencies and we'd like a solution per platform to keep Visual Studio performance issues to a minimum). I tried using the Condition property on a ProjectReference evaluating a value that I passed using /p:MyValue but it isn't recognized. It does work when I use it on GenerateSolutionFilePath mentioned here. I've looked at the code and I think the issue lies with the fact that the SolutionBuilder class doesn't pass globalProperties when loading the project collection.

Any idea if/how this can be fixed?

Thanks in advance,

Regards,

Wouter