xabbuh / pandabundle Goto Github PK

Given that the bundle now depend on video::getPayload(), it does not work anymore with stable releases of the client (see Travis).

You would need to release the 1.1 version of the client and bump the requirement in the bundle

AFAICT, the codebase should be compatible with Symfony 4 already. But the documentation is not (or the codebase if we don't want to change the doc at all).

The documentation is suggesting to use both the CloudManager and the clouds as public services. But services will be private by default in Symfony 4.
I suggest we keep them private, but document how to use them through service injection and autowiring (autowiring is not yet supported by default, but PR is coming)

The master branch advocates compatibility with Symfony 3. Can you make a new release including these changes ?

The diff since the latest release (1.4.1) contains fixes for a bunch of deprecations. It even has the changelog for 1.5.0. but the release has not been tagged.

It would be great to support PHP 8 in this bundle.

The changelog mentions a 2.0 release dropping support for Symfony 3.4 (and which will be the deprecation-free version for events when using 4.4). But there is no such tag yet.

The ContainerAwareCommand class is deprecated in Symfony 4.2

I'm currently working on updating the bundle for xabbuh/panda-client#16

The DI extension has lots of code dealing with the old way to configure a factory for a service (half of the services of the bundle have a factory). If we were dropping support for Symfony 2.3 to 2.5, we could move back the factory to the XML file, making things much more readable. I would then also drop support for 2.6 which is EOLed.

Among this versions, 2.4, 2.5 and 2.6 are EOLed since long. And the 2.3 LTS version is EOMed since nearly 1 year and will reach EOL (i.e. end of security fixes) at the end of May. So IMO, it is fine to stop supporting them.

What do you think @xabbuh ?

Symfony\Component\EventDispatcher\Event is deprecated as of Symfony 4.3 in favor of the new base class.