Giter Club home page Giter Club logo

Comments (2)

aabenoja avatar aabenoja commented on July 30, 2024 1

It is preferable to maintain our current approach of simply importing and dropping in components as needed without worrying about passing theme or wrapping our imports. Another approach that I'm leaning towards is the inverse where we wrap our exports with withTheme. In the example of button:

export default withTheme(Button);

This results in the following jsx body when rendered

<WithThemeButton>
  <Button>
    <ThemeProvider>
      { content }
    </ThemeProvider>
  </Button>
</WithThemeButton>

This approach maintains our ease of usability and styling and will respect all sources for theme in the following order

  1. Use the theme prop, if provided
  2. Will pull theme from the context provided by a parent ThemeProvider
  3. Fallback to the theme provided by default props, if any

from es-components.

Darrken avatar Darrken commented on July 30, 2024

I really like this export approach, @aabenoja!

from es-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.