Comments (4)
It looks like useWindowWidth()
is already using document.body.clientWidth
Update: I just realized this was suggesting instead of clientWidth.
from es-components.
Could you provide a jsfiddle or something demonstrating this? From what I can see, both document.body.clientWidth
and document.documentElement.clientWidth
return the same things, and do not include the margins.
The MDN Web docs say that these uses of clientWidth should be special cases that return the full viewport width minus the scrollbar only, and that's what I'm seeing with a simple test.
Body margin of 500px, inner wrapper of 50px:
from es-components.
It sounds like using document.documentElement.clientWidth
may be a safer option because it doesn't have the quirks-mode caveat.
from es-components.
Try to change width between 500 and 600 px
https://jsfiddle.net/manhust/j0tdrsyk/
from es-components.
Related Issues (20)
- Spacing variables
- Typescript Compatibility HOT 7
- Modal no longer scrolls content
- Date field allows the letter e, and other math symbols
- Popover Module unable to open on certain screen sizes
- Cannot tab backwards from DropdownButton
- Add Accessibility Testing to PRs HOT 3
- Tooltip is rendered under SlidingPane
- Hard Coded Domain Vulnerability
- Add more relative sizes to via-theme (small / large)
- v22 - Next Major Release
- Parity issues between BDA Toolkit, Sketch and ES Components HOT 7
- Validation Examples not working
- Popover styleType does not apply the style
- CheckboxGroup is uncontrollable after mounting
- Allow focus method to be called for household icons HOT 2
- DropdownButton component doesn't allow a user to navigate back to the previously focusable element.
- Fieldset component has CSS that is overriding standard color attribute
- Popover hasAltCloseButton prop prevents screenreader from reading content HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from es-components.