wtsi-hgi / thrifty-builder Goto Github PK
View Code? Open in Web Editor NEWBuilds Docker images, capturing information to reduce the frequency of future re-builds
License: MIT License
Builds Docker images, capturing information to reduce the frequency of future re-builds
License: MIT License
The process for setting up a development environment and running thrifty-builder tests is undocumented.
I think there is currently no way to pass build arguments to the build (as is done with docker build --build-arg FOO=bar
). The main use case I have for this is to build FROM a base image that has the same build version as the one I am currently building.
E.g. a dockerfile starting with:
ARG VERSION=latest
FROM base:${VERSION}
In order to support this, a new build config field would need to support passing of build args, and they'd have to be passed to docker build
as well as handled in Dockerfile ARG
lines.
If a checksum exists in the store, the tool currently dangeously assumes that it is uploaded to all registries. It would be good to verify this fact by associating the build SHA with the context checksum.
The builder has been observed to push a (cached) previous build of an image in the event of a build error, opposed to failing: https://gitlab.internal.sanger.ac.uk/hgi/hgi-systems/-/jobs/119206.
when a RUN
step fails, only the command line and exit code are shown, but not any of the stderr/stdout from the failed task. this makes it very difficult to diagnose problems.
Building all...
Building Docker image: foo/bar
Traceback (most recent call last):
File "/usr/local/bin/thrifty", line 10, in <module>
sys.exit(entrypoint())
File "/usr/local/lib/python3.6/site-packages/thriftybuilder/cli.py", line 156, in entrypoint
main(sys.argv[1:], None if sys.stdin.isatty() else sys.stdin.read())
File "/usr/local/lib/python3.6/site-packages/thriftybuilder/cli.py", line 99, in main
build_results = docker_builder.build_all()
File "/usr/local/lib/python3.6/site-packages/thriftybuilder/builders.py", line 188, in build_all
build_results = self.build(build_configuration, left_to_build, _checksum_storage=checksum_storage)
File "/usr/local/lib/python3.6/site-packages/thriftybuilder/builders.py", line 164, in build
build_result = self._build(build_configuration)
File "/usr/local/lib/python3.6/site-packages/thriftybuilder/builders.py", line 259, in _build
raise BuildStepError(build_configuration.name, error_details["message"], error_details.get("code"))
thriftybuilder.builders.BuildStepError: Build for foo/bar failed with exit code 127: The command '/bin/sh -c ./setup-dev-env.sh' returned a non-zero code: 127
Build artifacts are filling up our CI machines.
DockerBuilder
could support layer squashing on build.
Fixed in #11
Currently, the directory structure is not considered in the hash.
It is therefore possible to change paths without triggering a rebuild.
If both child and parent image are already built, the child is not rebuilt when the parent is.
The permissions of the source being COPY'd do not seem to factor in to the hash calculation.
Hash the symlink itself
The copy of an empty directory is not considered in the hash:
https://github.com/wtsi-hgi/thrifty-builder/blob/master/thriftybuilder/build_configurations.py#L92-L114
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.