wso2 / carbon-parent Goto Github PK

Documentation : Checklist for before and after releasing Carbon Parent pom

When building a component, below warnings can be observed.

[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!

----- Error occurrence -----

When you run the call to refresh_token service and the database is DB2, the following error occurs:

{
"error_description": "Error when validating a refresh token",
"error": "invalid_grant"
}

This occurs because the query of constant 'RETRIEVE_ACCESS_TOKEN_VALIDATION_DATA_DB2SQL' in class org.wso2.carbon.identity.oauth2.dao.SQLQueries is wrong.

----- Solution -----

Fix the query to:

SELECT ACCESS_TOKEN,
AUTHZ_USER,
ACCESS_TOKEN_SELECTED.TENANT_ID,
USER_DOMAIN,
TOKEN_SCOPE,
TOKEN_STATE,
REFRESH_TOKEN_TIME_CREATED,
REFRESH_TOKEN_VALIDITY_PERIOD,
ACCESS_TOKEN_SELECTED.TOKEN_ID,
GRANT_TYPE,
SUBJECT_IDENTIFIER
FROM
(SELECT ACCESS_TOKEN,
AUTHZ_USER,
TOKEN_STATE,
REFRESH_TOKEN_TIME_CREATED,
REFRESH_TOKEN_VALIDITY_PERIOD,
TOKEN_ID,
GRANT_TYPE,
SUBJECT_IDENTIFIER,
TENANT_ID,
USER_DOMAIN
FROM $accessTokenStoreTable
WHERE CONSUMER_KEY_ID =
(SELECT ID
FROM IDN_OAUTH_CONSUMER_APPS
WHERE CONSUMER_KEY = ?)
AND REFRESH_TOKEN = ?
ORDER BY TIME_CREATED DESC FETCH FIRST 1 ROWS ONLY) ACCESS_TOKEN_SELECTED
LEFT JOIN IDN_OAUTH2_ACCESS_TOKEN_SCOPE ON ACCESS_TOKEN_SELECTED.TOKEN_ID = IDN_OAUTH2_ACCESS_TOKEN_SCOPE.TOKEN_ID

In carbon-parent 5, the maven-assembly-plugin version used in 2.6.0. This can be upgraded to 3.0.0.

See PR: #22

Sometimes we need to skip javadoc generation for generated sources.

Throwing below error,
Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project osgi-tests: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /build/jenkins-home/workspace/platform-builds/carbon-deployment/tests/osgi-tests && /build/jenkins-home/software/java/jdk1.8.0_45/jre/bin/java '-javaagent:/build/jenkins-home/workspace/platform-builds/carbon-deployment/.repository/org/jacoco/org.jacoco.agent/0.7.5.201505241946/org.jacoco.agent-0.7.5.201505241946-runtime.jar=destfile=/build/jenkins-home/workspace/platform-builds/carbon-deployment/tests/osgi-tests/target/jacoco.exec,includes=org.wso2.carbon*' -jar /build/jenkins-home/workspace/platform-builds/carbon-deployment/tests/osgi-tests/target/surefire/surefirebooter5152829544684532020.jar /build/jenkins-home/workspace/platform-builds/carbon-deployment/tests/osgi-tests/target/surefire/surefire8592043572268409080tmp /build/jenkins-home/workspace/platform-builds/carbon-deployment/tests/osgi-tests/target/surefire/surefire_24347295732707164145tmp

Description:
The checkstyle plugin fails to build.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project wso2: Failed during checkstyle execution: Unable to find suppressions file at location: https://raw.githubusercontent.com/wso2/code-quality-tools/master/checkstyle/suppressions.xml: Could not find resource 'https://raw.githubusercontent.com/wso2/code-quality-tools/master/checkstyle/suppressions.xml'. -> [Help 1]

Suggested Labels:

Suggested Assignees:

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

mvn clean package

Related Issues: