RankByCountry is missing country codes about awis HOT 3 CLOSED

Many thanks for the PR! I just merged it and will be publishing a new version to npm in the next few minutes... ;-)

from awis.

Hi @lupomontero

Thanks for the quick response, really appreciate it. I have a few comments left:

#4 can probably closed now.

I also saw the code does a few things that xml2js already provides out of the box:

1. you can flatten the arrays automatically with explicitArray option.
2. you can lowercase names with the tagNameProcessors and attrNameProcessors. You can also use this to remove the namespace prefixes. There are standard firstCharLowerCase and stripPrefix processors provided.

from awis.

Hi @Janpot,

Thanks for all the help ;-)

I'm kinda busy with other stuff at the moment, can you open new issue and/or send a PR with the suggested changes?

Cheers,

L

from awis.