Comments (13)
Awesome, just published awis-sign-v4
that includes your PR. 👍
Just tested and it works perfectly! Even with an IAM user with the awis:GET
permission:
https://docs.aws.amazon.com/AlexaWebInfoService/latest/MakingRequestsChapter.html
Cheers @Janpot 🎉
When this gets merged by @lupomontero I'll go back to using awis
in production. As a reminder, the breaking change goes into effect tomorrow!
from awis.
Hi @lupomontero,
I can confirm the new version of awis
works. 👍
from awis.
@lupomontero Hope you're doing great. Did you get a chance to look at this mate?
from awis.
Hi @lupomontero,
Hope you're doing great!
I see that you self-assigned this, would just like to bring to your attention that in 14 days, the breaking change takes effect and the library will fail in production for everyone.
Please let me know if you will not be able to find time to work on this so that I will submit a PR instead.
from awis.
Hi @lupomontero,
Hope you're doing great.
A reply from you would be greatly appreciated. There are just 8 days left until the breaking change hits production.
Even a reply mentioning that you won't be able to work on it is fine. Just let us know so that we have sufficient time to develop a fix.
Thanks,
Elad
from awis.
@lupomontero @eladnava I went ahead and opened #21
Tests still fail for should allow apostrophe in path when doing CategoryBrowse
. No matter how I encode, it doesn't seem to accept the Path
parameter. If any of you could lend a second pair of eyes on this test?
I'm not using that part of the API and I don't have enough free time right now to devote on this.
from awis.
@Janpot looks awesome brother. Well done! 👍
Just wondering about line 137:
https://github.com/wrangr/awis/pull/21/files#diff-168726dbe96b3ce427e7fedce31bb0bcR137
Is the us-west-1
region hard-coded in the API endpoints intentionally? Are there any adverse effects to doing this?
In any case, I have a feeling @lupomontero will not be around to review, merge, and publish this to npm
in time for the breaking change.
Do you want to publish a temporary package to npm with the commits you made? If not, I'll be happy to do it as well.
from awis.
Is the
us-west-1
region hard-coded in the API endpoints intentionally?
Yes, aws4
uses us-east-1
as a region by default. This didn't work. The code samples provided by Amazon all used us-west-1
which worked for me.
It also looks right now that it works even without adding the policy.
right now we're importing it as
"awis": "git://github.com/Woorank/awis.git#aws-sign-v4",
We'll publish a version in a few weeks if @lupomontero stays inactive. You are free to publish a version if you don't want to import github dependencies.
from awis.
@Janpot Regarding the region, sounds good.
The breaking change that your PR addresses becomes active in January 31st, in just a few days time.
I will be happy to publish your fix as a new package in the meantime if you don't mind as I would like my production app to be able to access awis
without failure after the breaking change. 👍
from awis.
@eladnava and @Janpot: many apologies for the extended silence... 😢
I have been incredibly busy and had not had the time to review this until today. I finally reviewed the pending PR and merged it into master 🚀
WRT the failing tests (the one about the apostrophe), I have simply skipped it for now... I spent a little while just now trying to figure it out, but can't seem to...
On a different note, would any of you guys volunteer to help maintain this repo?
from awis.
I have just released a new version with the changes. Can you guys confirm whether this fixes the issue? Thanks!
from awis.
Thank you @lupomontero!
@eladnava can you note in your new module that it is deprecated then?
from awis.
Absolutely:
https://www.npmjs.com/package/awis-sign-v4
from awis.
Related Issues (18)
- Random failures HOT 5
- Error when apostrophe is in the path HOT 3
- RankByCountry is missing country codes HOT 3
- TopSites HOT 3
- An in-range update of mocha is breaking the build 🚨 HOT 1
- URGENT: Use HTTPS endpoint for AWIS and Alexa TopSites API HOT 3
- An in-range update of eslint-config-hapi is breaking the build 🚨 HOT 1
- are you using https when connecting to the API? HOT 1
- CORS
- Error: AuthFailure: AWS was not able to validate the provided access credential HOT 1
- Version 10 of node.js has been released
- Where to include the IAM user access key id and secret access
- Bug in region setting? HOT 2
- An in-range update of lodash is breaking the build 🚨 HOT 4
- An in-range update of xml2js is breaking the build 🚨 HOT 4
- An in-range update of aws4 is breaking the build 🚨 HOT 1
- An in-range update of request is breaking the build 🚨 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awis.