Giter Club home page Giter Club logo

wpplugin's Introduction

wpplugin's People

Contributors

dependabot[bot] avatar dimaminka avatar ihorvorotnov avatar joycebabu avatar oleg-valko-pro avatar wppunk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wpplugin's Issues

Init project

  • Basic structure
  • Autoload
  • WPCS
  • Custom ruleset for CS (PSR-4, short array, PHPCompatibility)
  • Codeception tests (acceptances, integrations, unit)
  • Unit tests AspectMock for Hard Dependencies
  • Gulp (SCSS, JS6, Img, Watch, Zip, Build)
  • GitHub actions

Zorca's enhacements list

List of enhancements:

  • Create additional repository for plugin generator (WP-CLI based for example)
  • Change template variables syntax to mustache syntax: {{ VARIABLE }}
  • Improve documentation about PostCSS features
  • Add functionality for change frontend framework (SCSS or another package, option for WP-CLI generator)

wpbro features

  • Rebranding script or doc

  • Plugin additional details in plugins list

  • modules features like in acf-wpi (we talking about that)

  • acf integration with some example if original acf activated

  • wp cli new module creation

`composer init-project` errors out when it runs `php-scoper add-prefix`

Please provide us with the information requested in this bug report. Without these details, we won't be able to fully evaluate this issue.
Bug reports lacking detail, or for any other reason than to report a bug, may be closed without action.

Prerequisites (mark completed items with an [x]):

  • I have have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug
Following the instructions in the README for initial setup using composer init-project yields an error when it executes php-scoper add-prefix

Expected behavior
I expect to find no errors following README instructions for setup

Actual behavior
I get the following error:

> php-scoper add-prefix --config .scoper.inc.php --output-dir vendor_prefixed/

In ConfigurationFactory.php line 198:
                                                                       
  Invalid configuration key value "whitelist-global-constants" found.  

Steps to reproduce the bug (We need to be able to reproduce the bug in order to fix it.)
Steps to reproduce the bug:

  1. git clone https://github.com/wppunk/WPPlugin.git
  2. cd WPPlugin
  3. composer init-project
  4. Enter name, author, url, etc
  5. Enter 'y' for Do you trust "bamarni/composer-bin-plugin" to execute code and wish to enable it now?
  6. Enter 'y' for Do you trust "dealerdirect/phpcodesniffer-composer-installer" to execute code and wish to enable it now?

Output

❯ composer init-project
> composer require wppunk/wpplugin-replace --dev
Info from https://repo.packagist.org: #StandWithUkraine
./composer.json has been updated
Running composer update wppunk/wpplugin-replace
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking wppunk/wpplugin-replace (v0.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 90 installs, 0 updates, 0 removals
  - Downloading bamarni/composer-bin-plugin (1.4.1)
  - Downloading squizlabs/php_codesniffer (3.6.0)
  - Downloading dealerdirect/phpcodesniffer-composer-installer (v0.7.1)
  - Downloading behat/gherkin (v4.8.0)
  - Downloading hamcrest/hamcrest-php (v2.0.1)
  - Downloading mockery/mockery (1.3.5)
  - Downloading antecedent/patchwork (2.1.15)
  - Downloading brain/monkey (2.6.0)
  - Downloading sebastian/diff (3.0.3)
  - Downloading sebastian/recursion-context (3.0.1)
  - Downloading sebastian/exporter (3.1.3)
  - Downloading sebastian/comparator (3.0.3)
  - Downloading sebastian/version (2.0.1)
  - Downloading sebastian/type (1.1.4)
  - Downloading sebastian/resource-operations (2.0.2)
  - Downloading sebastian/object-reflector (1.1.2)
  - Downloading sebastian/object-enumerator (3.0.4)
  - Downloading sebastian/global-state (3.0.1)
  - Downloading sebastian/environment (4.2.4)
  - Downloading phpunit/php-timer (2.1.3)
  - Downloading phpunit/php-text-template (1.2.1)
  - Downloading phpunit/php-file-iterator (2.0.4)
  - Downloading sebastian/code-unit-reverse-lookup (1.0.2)
  - Downloading phpunit/php-token-stream (3.1.3)
  - Downloading phpunit/php-code-coverage (7.0.15)
  - Downloading symfony/polyfill-ctype (v1.23.0)
  - Downloading webmozart/assert (1.10.0)
  - Downloading phpdocumentor/reflection-common (2.2.0)
  - Downloading phpdocumentor/type-resolver (1.5.1)
  - Downloading phpdocumentor/reflection-docblock (5.2.2)
  - Downloading doctrine/instantiator (1.4.0)
  - Downloading phpspec/prophecy (1.14.0)
  - Downloading phar-io/version (3.1.0)
  - Downloading myclabs/deep-copy (1.10.2)
  - Downloading phpunit/phpunit (8.5.21)
  - Downloading codeception/phpunit-wrapper (8.1.4)
  - Downloading symfony/deprecation-contracts (v2.4.0)
  - Downloading symfony/yaml (v5.3.6)
  - Downloading symfony/polyfill-php80 (v1.23.1)
  - Downloading symfony/finder (v5.3.7)
  - Downloading symfony/event-dispatcher-contracts (v2.4.0)
  - Downloading symfony/event-dispatcher (v5.3.7)
  - Downloading symfony/css-selector (v5.3.4)
  - Downloading symfony/polyfill-mbstring (v1.23.1)
  - Downloading symfony/polyfill-intl-normalizer (v1.23.0)
  - Downloading symfony/polyfill-intl-grapheme (v1.23.1)
  - Downloading symfony/string (v5.3.7)
  - Downloading psr/container (1.1.1)
  - Downloading symfony/service-contracts (v2.4.0)
  - Downloading symfony/polyfill-php73 (v1.23.0)
  - Downloading symfony/console (v5.3.7)
  - Downloading psr/http-message (1.0.1)
  - Downloading psr/http-factory (1.0.1)
  - Downloading guzzlehttp/psr7 (2.1.0)
  - Downloading codeception/stub (3.7.0)
  - Downloading codeception/codeception (4.1.22)
  - Downloading codeception/module-db (1.1.0)
  - Downloading symfony/process (v5.3.7)
  - Downloading php-webdriver/webdriver (1.11.1)
  - Downloading codeception/module-webdriver (1.4.0)
  - Downloading doctrine/inflector (2.0.3)
  - Downloading psr/simple-cache (1.0.1)
  - Downloading illuminate/contracts (v7.30.4)
  - Downloading wp-cli/php-cli-tools (v0.11.13)
  - Downloading mustache/mustache (v2.13.0)
  - Downloading wp-cli/wp-cli (v2.5.0)
  - Downloading voku/portable-ascii (1.5.6)
  - Downloading symfony/translation-contracts (v2.4.0)
  - Downloading symfony/translation (v5.3.9)
  - Downloading nesbot/carbon (2.53.1)
  - Downloading illuminate/support (v7.30.4)
  - Downloading bordoni/phpass (0.3.5)
  - Downloading mikehaertl/php-shellcommand (1.6.4)
  - Downloading lucatume/wp-browser (3.0.11)
  - Downloading rdlowrey/auryn (v1.4.4)
  - Downloading wp-coding-standards/wpcs (2.3.0)
  - Downloading wppunk/wpplugin-replace (v0.1)
bamarni/composer-bin-plugin contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "bamarni/composer-bin-plugin" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?] y
  - Installing bamarni/composer-bin-plugin (1.4.1): Extracting archive
  - Installing squizlabs/php_codesniffer (3.6.0): Extracting archive
dealerdirect/phpcodesniffer-composer-installer contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "dealerdirect/phpcodesniffer-composer-installer" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?] y
  - Installing dealerdirect/phpcodesniffer-composer-installer (v0.7.1): Extracting archive
  - Installing behat/gherkin (v4.8.0): Extracting archive
  - Installing hamcrest/hamcrest-php (v2.0.1): Extracting archive
  - Installing mockery/mockery (1.3.5): Extracting archive
  - Installing antecedent/patchwork (2.1.15): Extracting archive
  - Installing brain/monkey (2.6.0): Extracting archive
  - Installing sebastian/diff (3.0.3): Extracting archive
  - Installing sebastian/recursion-context (3.0.1): Extracting archive
  - Installing sebastian/exporter (3.1.3): Extracting archive
  - Installing sebastian/comparator (3.0.3): Extracting archive
  - Installing sebastian/version (2.0.1): Extracting archive
  - Installing sebastian/type (1.1.4): Extracting archive
  - Installing sebastian/resource-operations (2.0.2): Extracting archive
  - Installing sebastian/object-reflector (1.1.2): Extracting archive
  - Installing sebastian/object-enumerator (3.0.4): Extracting archive
  - Installing sebastian/global-state (3.0.1): Extracting archive
  - Installing sebastian/environment (4.2.4): Extracting archive
  - Installing phpunit/php-timer (2.1.3): Extracting archive
  - Installing phpunit/php-text-template (1.2.1): Extracting archive
  - Installing phpunit/php-file-iterator (2.0.4): Extracting archive
  - Installing theseer/tokenizer (1.2.1): Extracting archive
  - Installing sebastian/code-unit-reverse-lookup (1.0.2): Extracting archive
  - Installing phpunit/php-token-stream (3.1.3): Extracting archive
  - Installing phpunit/php-code-coverage (7.0.15): Extracting archive
  - Installing symfony/polyfill-ctype (v1.23.0): Extracting archive
  - Installing webmozart/assert (1.10.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing phpdocumentor/type-resolver (1.5.1): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.2.2): Extracting archive
  - Installing doctrine/instantiator (1.4.0): Extracting archive
  - Installing phpspec/prophecy (1.14.0): Extracting archive
  - Installing phar-io/version (3.1.0): Extracting archive
  - Installing phar-io/manifest (2.0.3): Extracting archive
  - Installing myclabs/deep-copy (1.10.2): Extracting archive
  - Installing phpunit/phpunit (8.5.21): Extracting archive
  - Installing codeception/phpunit-wrapper (8.1.4): Extracting archive
  - Installing codeception/lib-asserts (1.13.2): Extracting archive
  - Installing symfony/deprecation-contracts (v2.4.0): Extracting archive
  - Installing symfony/yaml (v5.3.6): Extracting archive
  - Installing symfony/polyfill-php80 (v1.23.1): Extracting archive
  - Installing symfony/finder (v5.3.7): Extracting archive
  - Installing psr/event-dispatcher (1.0.0): Extracting archive
  - Installing symfony/event-dispatcher-contracts (v2.4.0): Extracting archive
  - Installing symfony/event-dispatcher (v5.3.7): Extracting archive
  - Installing symfony/css-selector (v5.3.4): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.23.1): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.23.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.23.1): Extracting archive
  - Installing symfony/string (v5.3.7): Extracting archive
  - Installing psr/container (1.1.1): Extracting archive
  - Installing symfony/service-contracts (v2.4.0): Extracting archive
  - Installing symfony/polyfill-php73 (v1.23.0): Extracting archive
  - Installing symfony/console (v5.3.7): Extracting archive
  - Installing ralouphie/getallheaders (3.0.3): Extracting archive
  - Installing psr/http-message (1.0.1): Extracting archive
  - Installing psr/http-factory (1.0.1): Extracting archive
  - Installing guzzlehttp/psr7 (2.1.0): Extracting archive
  - Installing codeception/stub (3.7.0): Extracting archive
  - Installing codeception/codeception (4.1.22): Extracting archive
  - Installing codeception/module-asserts (1.3.1): Extracting archive
  - Installing codeception/module-db (1.1.0): Extracting archive
  - Installing symfony/process (v5.3.7): Extracting archive
  - Installing php-webdriver/webdriver (1.11.1): Extracting archive
  - Installing codeception/module-webdriver (1.4.0): Extracting archive
  - Installing doctrine/inflector (2.0.3): Extracting archive
  - Installing psr/simple-cache (1.0.1): Extracting archive
  - Installing illuminate/contracts (v7.30.4): Extracting archive
  - Installing zordius/lightncandy (v1.2.6): Extracting archive
  - Installing wp-cli/php-cli-tools (v0.11.13): Extracting archive
  - Installing wp-cli/mustangostang-spyc (0.6.3): Extracting archive
  - Installing rmccue/requests (v1.8.1): Extracting archive
  - Installing mustache/mustache (v2.13.0): Extracting archive
  - Installing wp-cli/wp-cli (v2.5.0): Extracting archive
  - Installing vria/nodiacritic (0.1.2): Extracting archive
  - Installing voku/portable-ascii (1.5.6): Extracting archive
  - Installing symfony/translation-contracts (v2.4.0): Extracting archive
  - Installing symfony/translation (v5.3.9): Extracting archive
  - Installing nesbot/carbon (2.53.1): Extracting archive
  - Installing illuminate/support (v7.30.4): Extracting archive
  - Installing bordoni/phpass (0.3.5): Extracting archive
  - Installing mikemclin/laravel-wp-password (2.0.3): Extracting archive
  - Installing mikehaertl/php-shellcommand (1.6.4): Extracting archive
  - Installing dg/mysql-dump (v1.5.1): Extracting archive
  - Installing lucatume/wp-browser (3.0.11): Extracting archive
  - Installing phpcompatibility/php-compatibility (9.3.5): Extracting archive
  - Installing rdlowrey/auryn (v1.4.4): Extracting archive
  - Installing wp-coding-standards/wpcs (2.3.0): Extracting archive
  - Installing wppunk/wpplugin-replace (v0.1): Extracting archive
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
43 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../phpcompatibility/php-compatibility,../../wp-coding-standards/wpcs
Found 3 security vulnerability advisories affecting 2 packages.
Run composer audit for a full list of advisories.
Using version ^0.1.0 for wppunk/wpplugin-replace
> @php vendor/wppunk/wpplugin-replace/wpplugin-replace.php
Plugin name (Example: Plugin Name): AutoloadTest
PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49
Version (Default: 1.0.0): 
PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49
Plugin url (Example: https://gitub.com/wppunk/WPPlugin. Default: ''): 
PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49
Author (Example: wppunk. Default: ''): me
PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49
Author url (Example: https://gitub.com/wppunk/. Default: ''): me.com
PHP Deprecated:  Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /Users/matthew/Code/WPPlugin/vendor/wppunk/wpplugin-replace/src/Wizard.php on line 49
Replacing plugin...
........................ 24/24
Plugin variables were replaced.
> composer remove wppunk/wpplugin-replace --dev
./composer.json has been updated
Running composer update wppunk/wpplugin-replace
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 0 updates, 1 removal
  - Removing wppunk/wpplugin-replace (v0.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 0 updates, 1 removal
  - Removing wppunk/wpplugin-replace (v0.1)
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
43 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Found 3 security vulnerability advisories affecting 2 packages.
Run composer audit for a full list of advisories.
> composer build
> composer require rdlowrey/auryn
./composer.json has been updated
Running composer update rdlowrey/auryn
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Writing lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
43 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Found 3 security vulnerability advisories affecting 2 packages.
Run composer audit for a full list of advisories.
Using version ^1.4 for rdlowrey/auryn
> composer scoper -n
> composer bin php-scoper config minimum-stability dev
> composer bin php-scoper config prefer-stable true
> composer bin php-scoper require --dev humbug/php-scoper
./composer.json has been updated
Running composer update humbug/php-scoper
Loading composer repositories with package information
Updating dependencies
Lock file operations: 19 installs, 0 updates, 0 removals
  - Locking fidry/console (0.5.5)
  - Locking humbug/php-scoper (0.18.3)
  - Locking jetbrains/phpstorm-stubs (v2022.3)
  - Locking nikic/php-parser (v4.16.0)
  - Locking psr/container (2.0.2)
  - Locking psr/event-dispatcher (1.0.0)
  - Locking symfony/console (v6.3.2)
  - Locking symfony/deprecation-contracts (v3.3.0)
  - Locking symfony/event-dispatcher-contracts (v3.3.0)
  - Locking symfony/filesystem (v6.3.1)
  - Locking symfony/finder (v6.3.3)
  - Locking symfony/polyfill-ctype (v1.27.0)
  - Locking symfony/polyfill-intl-grapheme (v1.27.0)
  - Locking symfony/polyfill-intl-normalizer (v1.27.0)
  - Locking symfony/polyfill-mbstring (v1.27.0)
  - Locking symfony/service-contracts (v3.3.0)
  - Locking symfony/string (v6.3.2)
  - Locking thecodingmachine/safe (v2.5.0)
  - Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 19 installs, 0 updates, 0 removals
  - Downloading thecodingmachine/safe (v2.5.0)
  - Downloading symfony/finder (v6.3.3)
  - Downloading symfony/filesystem (v6.3.1)
  - Downloading symfony/string (v6.3.2)
  - Downloading psr/container (2.0.2)
  - Downloading symfony/service-contracts (v3.3.0)
  - Downloading symfony/deprecation-contracts (v3.3.0)
  - Downloading symfony/console (v6.3.2)
  - Downloading jetbrains/phpstorm-stubs (v2022.3)
  - Downloading webmozart/assert (1.11.0)
  - Downloading symfony/event-dispatcher-contracts (v3.3.0)
  - Downloading fidry/console (0.5.5)
  - Downloading humbug/php-scoper (0.18.3)
  0/13 [>---------------------------]   0%
  5/13 [==========>-----------------]  38%
  8/13 [=================>----------]  61%
 10/13 [=====================>------]  76%
 11/13 [=======================>----]  84%
 12/13 [=========================>--]  92%
 13/13 [============================] 100%
  - Installing thecodingmachine/safe (v2.5.0): Extracting archive
  - Installing symfony/finder (v6.3.3): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.27.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.27.0): Extracting archive
  - Installing symfony/filesystem (v6.3.1): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.27.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.27.0): Extracting archive
  - Installing symfony/string (v6.3.2): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.3.0): Extracting archive
  - Installing symfony/deprecation-contracts (v3.3.0): Extracting archive
  - Installing symfony/console (v6.3.2): Extracting archive
  - Installing nikic/php-parser (v4.16.0): Extracting archive
  - Installing jetbrains/phpstorm-stubs (v2022.3): Extracting archive
  - Installing webmozart/assert (1.11.0): Extracting archive
  - Installing psr/event-dispatcher (1.0.0): Extracting archive
  - Installing symfony/event-dispatcher-contracts (v3.3.0): Extracting archive
  - Installing fidry/console (0.5.5): Extracting archive
  - Installing humbug/php-scoper (0.18.3): Extracting archive
  0/19 [>---------------------------]   0%
 17/19 [=========================>--]  89%
 18/19 [==========================>-]  94%
 19/19 [============================] 100%
Generating autoload files
12 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
Using version ^0.18.3 for humbug/php-scoper
> php-scoper add-prefix --config .scoper.inc.php --output-dir vendor_prefixed/


In ConfigurationFactory.php line 198:
                                                                       
  Invalid configuration key value "whitelist-global-constants" found.  
                                                                       

add-prefix [-d|--working-dir WORKING-DIR] [-p|--prefix PREFIX] [-o|--output-dir OUTPUT-DIR] [-f|--force] [-s|--stop-on-failure] [-c|--config CONFIG] [--no-config] [--] [<paths>...]

Script php-scoper add-prefix --config .scoper.inc.php --output-dir vendor_prefixed/ handling the scoper event returned with error code 1
Script composer scoper -n handling the build event returned with error code 1
Script composer build handling the init-project event returned with error code 1

WordPress Environment
Not applicable

Incorrect PSR namespace?

Autoload section of composer.json has the following entry

"PluginName\\Dependencies\\": "dependencies/psr/"

But isn't PSR dependencies loaded from PluginName\Vendor? I couldn't find any instances where PluginName\Dependencies is defined.

Do not hardcode admin URLs in acceptance tests

Prerequisites (mark completed items with an [x]):

  • I have have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

$I->amOnPage( '/wp-admin/admin.php?page=plugin-name' ); will fail if WordPress is installed in its own directory.

See https://github.com/wppunk/WPPlugin/blob/master/.tests/php/acceptance/SettingsCest.php#L32

Use $I->amOnAdminPage( '/admin.php?page=plugin-name' ); instead. See docs.

Expected behavior

Tests should work fine on any official / valid WordPress install types.

Actual behavior

If WordPress is installed in its own directory, acceptance tests will fail to execute.

Steps to reproduce the bug (We need to be able to reproduce the bug in order to fix it.)
Steps to reproduce the bug:

  1. Install WordPress into its own directory
  2. Run acceptance tests
  3. See error

WordPress Environment

Any WordPress version installed in its own directory.

Dependency conflict

Right now the the plugin requires both the original vendor/ directory (for autoloading) and the dependencies/vendor directory for the prefixed dependencies. The unused un-prefixed dependencies may still conflict with other plugins, that depends on a separate version of the the same package.

Google site kit solves this by generating a separate classmap based autoloader that does not require the original vendor directory.

Or am I missing something?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.