Giter Club home page Giter Club logo

Comments (4)

Alextopher avatar Alextopher commented on August 18, 2024

I think removing is the right choice since that is what was done in #6673.

Once we decide which of removing and deprecating we want to do, this would be a great first PR for somebody looking to start contributing to WPILib!

I'm interesting in taking this on

from allwpilib.

KangarooKoala avatar KangarooKoala commented on August 18, 2024

I think removing is the right choice since that is what was done in #6673.

I'm not sure I get what you mean by this- #6673 removed all usages of WheelPositions in our kinematics, odometry, and pose estimator classes, but it didn't touch WheelPositions itself.

That said, WheelPositions should only be used by kinematics implementations for custom drivebase types, so it's probably fine to remove it without warning (like we did to SwerveDriveWheelPositions). @calcmogul what do you think?

I'm interesting in taking this on

Great! Looks you've already opened a wpilib PR, but let us know if you have any questions! (e.g., how to run formatting and compile locally)

from allwpilib.

Alextopher avatar Alextopher commented on August 18, 2024

Ah - I misunderstood the scope of the change. I understand what you are looking for now.

from allwpilib.

calcmogul avatar calcmogul commented on August 18, 2024

Yea, WheelPositions was only used by us, so it can be removed now that nothing references it.

from allwpilib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.