worldhealthorganization / ddcc Goto Github PK

Assuming this is the right choice the text "An SVC_Patient should: set the identifier.assigner to reference the SVC Organization resource associated to the PHA via the WHO Public Key Directory" is not aligned with the profile

Document: FHIR.WHO.SVC-RC1\SVC Patient - FHIR v4.0.1
Section: Resource Profile: SVC Patient
Organization: Giorgio Cangioli
Mail: [email protected]

I assume the misleading text I am going to describe is based on something in this repository.

See attached ddcc-2.png which is a screen capture from the Table of Contents. It shows 22.44 with a label of DDCC:VS Document. I think that should be DDCC:TR Document.

See attached ddcc-1.png which is a screen capture when you click through to https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCTRDocument.html. Note the mismatch between TR and VS in several places.

Not clear why coding is 1..1 in the vaccineCode, this prevent to use any othee additional vaccine code or product identifier (e.g. IDMP PhPIDs). Suggest to slice the coding imposing to have at least one coding based on ICD11

Document: FHIR.WHO.SVC-RC1\SVC Immunization - FHIR v4.0.1
Section: Formal Views of Profile Content
Organization: Giorgio Cangioli
Mail: [email protected]

See https://registry.fhir.org/results?query=%22fhir.who.ddcc%22&latestFilter=true.

The FHIR Package Registry is the place where all tooling will find the package (like IG publisher, Simplifier, Forge, etc.), so with the package being absent from there it will be hard for others to install it, load it to a server or build a derived specification.

Information on publishing can be found here: https://registry.fhir.org/submit (with the comment that a feed should actually be listed here now: https://github.com/FHIR/ig-registry/blob/master/package-feeds.json, not in https://github.com/FHIR/ig-registry/blob/master/fhir-ig-list.json) or here: https://confluence.hl7.org/display/FHIR/FHIR+Package+Registry+User+Documentation#FHIRPackageRegistryUserDocumentation-Addingapackagetotheregistry

It would be beneficial to include some actual examples of the actual FHIR instances for test result certificates, specifically the universal profiles for the lab result (if it is, I could not find these artifacts), This is the specific profile we would expect to be used: http://hl7.org/fhir/uv/shc-vaccination/StructureDefinition/shc-infectious-disease-laboratory-result-observation-dm) and if there is discordance with the WHO specification data element requirements that feedback should be provided back to the IG authors at HL7, so that we don't end up with 2 different versions (one that was HL7 balloted and one that was not).

Several of header element IDs in input/pagecontent/transactions.xml are not unique, causing certain headers to incorrectly link to other parts of the page.

For example, attempting to link to the Register Health Certificate - Message Semantics section (20.3.2) actually links back up to the Submit Health Event - Message Semantics section (20.1.2).

In case those maintaining this repository were not aware, a few of the members in the W3C Credentials Community Group have been working on a Vaccination Certificate Vocabulary that is compatible with the WHO SVC work. The W3C CCG has also been working on a Verifiable Credentials HTTP API.

For those that are not familiar with the W3C CCG, it is the group (consisting of 400+ members) that created and standardized the Verifiable Credentials and Decentralized Identifier global standards (among many others that are currently being developed). These standards are used by a large number of digital vaccination certificate projects around the world (EU, US, NZ, etc.).

We (Digital Bazaar) thought it might be interesting to see if we could create an interoperability test suite for the WHO Smart Vaccination Card work using the tools listed above.

The test suite covers 28 types of vaccines that are covered in the SVC work, including Measles, Smallpox, Polio, Yellow Fever, COVID-19, and others.

Please note:

• This is all experimental; it's not meant to step on any toes (the 40+ other vaccination certificate projects).
• The solution is designed to address all goals listed in the recently published WHO document on SVCs.
• The certificates, dictionaries, and tests will track changes WHO SVC work (and are designed to be rapidly regenerated and tested).

With that said, we've been able to achieve the following:

• A test suite containing 1,624 tests covering the 28 vaccine types in the WHO SVC dictionary.
• 7 independent vendor implementations issuing and verifying each others WHO Smart Vaccination Cards.
• 1,623 passing tests demonstrating objective results wrt. technical interoperability.

You can view the latest Vaccination Certificate test suite report here:

https://w3id.org/vaccination/interop-reports

The announcement to the W3C Credentials Community Group is here:

https://lists.w3.org/Archives/Public/public-credentials/2021Apr/0081.html

How can we best coordinate the test suite work with WHO?

@lukeaduncan @ritikarawlani are we missing a $ in front of SCT here?

From Zulip: The description says 'Individual or organization who was performing' but the only permitted target for the reference is SVC Practitioner - shouldn't SVC Organization be allowed also?

After reviewing the DDCC specification (see following link) with Carl LEITNER and IHE, we conclud the actor name "Verifier" need to be replaced by “DDCC:Verifier application” in the following transactions :

• Retrieve Health Certificate Reference
• Retrieve Health Certificate
• Retrieve Health Folder

Link to the transactions - https://worldhealthorganization.github.io/ddcc/transactions.html

Are you planning to add the SVC logical model to the guide ?

https://worldhealthorganization.github.io/ddcc/CodeSystem-DDCC-ICD11-CodeSystem.html

I see multiple examples in the IPS documents where there are validation warnings that the CodeSystem is not known: http://id.who.int/icd11/mms , according to zulip it should be http://id.who.int/icd/release/11/mms , (https://chat.fhir.org/#narrow/stream/179166-implementers/topic/ICD-11.20system.20URL) does anybody have some additional background on that why this IG is using http://id.who.int/icd11/mms ?

IG to include how to implement the Interim Guidance using interoperability standards. For example, there is no mention related to the HL7 SMART Healthcard.
Additional detail and a high-level summary of how and where existing and proposed HL7 standards are being leveraged, including relevant HL7 FHIR IGs and the HL7 SMART Healthcard

1. the first entry of a document bundle is always a Composition

test feedback 2406

Document: FHIR.WHO.SVC-RC1\Narrative - FHIR v4.0.1
Section: Narrative
Organization: JCT
Mail:

Documentation for the Submit Health Event transaction suggests that DDCCSubmitHealthEventRequest is a batch Bundle of Parameters, but the Bundle entry slice for ddccParameters has cardinality 0..1, which suggests you can only have up to one Parameters resource in the bundle entries.

The Patient (https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCPatient.html) and Immunization (https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCImmunization.html) profiles are based on the core resources

I assume this is a mistake and they should be based on the 'special' IPS ones: https://worldhealthorganization.github.io/ddcc/StructureDefinition-Patient-pre-uv-ips.html and https://worldhealthorganization.github.io/ddcc/StructureDefinition-Immunization-pre-uv-ips.html

I don't get the idea behind the SVC Patient appearing both in the Bundle AND the Composition, both 1.1. required. What is the rationale behind that duplication? Suggestion to keep the Composition->subject as THE patient, to remove the Bundle->patient and to move the Bundle->provence into the composition.

Document: FHIR.WHO.SVC-RC1\SVC Bundle - FHIR v4.0.1
Section: Formal Views of Profile Content
Organization: Dr Kai Heitmann, health innovation hub, MoH Germany
Mail: [email protected]

Before publishing we need to agree on how to manage the dependency with the IPS guide.

To fulfill the SVC requirements this guide should depend on the dev version of the IPS guide.

Test feedback

Document: FHIR.WHO.SVC-RC1\Narrative - FHIR v4.0.1
Section: Summary
Organization: JCT
Mail: [email protected]

comment

Document: document
Section: section
Organization: organization
Mail: mail

According to the Expected Actions of a Submit Health Event transaction:

"The DDCC:VS Generation Service...shall generate and sign a DDCC Document"

However, since a DDCC Document's Bundle.signature is not required, any validation using this profile will not check for the existence of a signature, which seems to be an integral part of the Submit Health Event response.

There are clearly reasons why signature cannot be required (i.e. the DDCCDocument cannot have a signature before it is signed). Therefore we propose creating a new DDCCDocumentSigned profile that would allow for the validation of a signed DDCC Document, as is expected by the response of a Submit Health Event transaction.

DDCC:TR guidance document points to the HL7 International Patient Summary (IPS), but unless the above mentioned artifact page is located that lists a few IPS profiles, this connection is not as transparent as it should be.

In the DDCC workflow (see attached link) you need to take into account following changes
https://worldhealthorganization.github.io/ddcc/workflows.html

• Workflow step 07: Change “IHE: ATNA” to “IHE: ATNA, ITI-19 Authenticate Node”
• Workflow step 08: Change “IHE: ATNA (restful)” to “IHE: ATNA, ITI-20 Record Audit Event (restful)”
• Workflow step 11: Change “MHDS: ITI-65 …” to “IHE: MHD, ITI-65 …” (same everywhere to be consistent)

https://github.com/who-int/svc/blob/rc2/input/fsh/svc-valuesets.fsh#L129-L137 should be deleted

**What is the rationale behind putting the Digital Signature on the Provenance resource, and not on the Bundle as an "envelope?" Is the intention to use the x-provenance header to submit the Provenance as the Provenance on the Bundle? or is the Provenance resource referring to the Composition Resource? **

Document: FHIR.WHO.SVC-RC2\Provenance of SVC - FHIR v4.0.1
Section: Resource Profile: Provenance of SVC
Organization: Alex Goel Independent
Mail: [email protected]

The Submit Health Event Transaction expects to be returned: “a DDCC Submit Health Event Response which consists of a Bundle of type batch-response following the FHIR specification for transaction responses.” (According to the Message Semantics Response section of the spec).

The following is how the FHIR specification for transactions responses defines this response:

For a batch, or a successful transaction, the response the server SHALL return a Bundle with type set to batch-response or transaction-response that contains one entry for each entry in the request, in the same order, with the outcome of processing the entry. For a failed transaction, the server returns a single OperationOutcome instead of a Bundle.

A client may use the returned Bundle to track the outcomes of processing the entry, and the identities assigned to the resources by the server. Each entry element SHALL contain a response element which details the outcome of processing the entry - the HTTP status code, and the location and ETag header values, which are used for identifying and versioning the resources. In addition, a resource may be included in the entry, as specified by the Prefer header.

FHIR Core currently defines an invariant (bdl-4) that makes the Bundle.entry.response element required for all Bundles of type 'batch-response'. But within the response element, only Bundle.entry.response.status is required. According to the language above, should the DDCC Submit Health Event Response Profile additionally be making Bundle.entry.response.location and Bundle.entry.response.etag required, since the spec directly points to this language saying that these elements SHALL be returned?

The ICD-11 canonical url is http://id.who.int/icd11/mms and not http://hl7.org/fhir/sid/icd-11 (see https://confluence.hl7.org/pages/viewpage.action?pageId=97481986)

Document: FHIR.WHO.SVC-RC1\WHO Vaccine List - FHIR v4.0.1
Section: ValueSet: WHO Vaccine List
Organization: Giorgio Cangioli
Mail: [email protected]

This does not readily make the specific FHIR artifacts available; it would be better to actually point to the applicable artifacts on this page: https://worldhealthorganization.github.io/ddcc/artifacts.html, which is still missing the observation or DiagnosticReport profiles for test result

test 2

Document: test
Section: Artifacts Summary
Organization: JCT
Mail:

Links to https://worldhealthorganization.github.io/ddcc/history.html that returns a 404

This is the first test feedback

Document: FHIR.WHO.SVC-RC1\Narrative - FHIR v4.0.1
Section: Narrative
Organization: Jose Costa Teixeira
Mail: