Comments (2)
Hi Thijs,
The reasons for not implementing this (yet) is:
- The Redis list of commands is massive, supporting all commands requires writing much wrapper code that must be maintained
- Erldis tried implementing all commands, but as Redis added more commands, it was falling behind. This led to a situation where you would have to patch it on your own and try to get your stuff merged back.
- When for example using a dict-like API, you would expect it to behave like a dict, ie. throw an exception if "fetch" fails, etc.
- In our systems we want to hide all database access inside it's own module/layer, so not having these wrappers doesn't really make that much of a difference.
- There is the issue of types: eredis:q/2 accepts an iolist, an API would have to accept types that makes sense for the API. eredis:q/2 returns {ok, DataFromRedis} if everything is ok, this is consistent across all commands and a wrapper API would have to return something that makes sense for that API call which means lots of translations and choices.
- You still need to know exactly which client you want to use, so eredis:q(MyMasterDatabase, ["SET", "foo", "bar"]), would become eredis:set(MyMasterDatabase, "foo", "bar").
With that said, I do agree that it would be a nice-to-have to offer a more high-level API. For inspiration I would suggest looking at erldis(https://github.com/cstar/erldis). In my opinion an API could offer a dict-behaviour, a list-behaviour, a sets-behaviour and a sorted-sets-behaviour.
from eredis.
Thanks for the explanation. I didn't know that the Redis api was still changing, but that would be a good reason to wait. I'll take a look at erldis later, but the pubsub feature would be more fun to add first :)
from eredis.
Related Issues (20)
- authenticate fail , wrong password.
- get_all_messages only gets one message? HOT 1
- Error after running test HOT 7
- Is there any method like qp_noreply? HOT 1
- Getting wrong value for HINCRBYFLOAT
- {error,{unexpected_data,{error,closed}}} - during Authentication HOT 1
- Don't log error on start HOT 1
- eredis Crash is killing my microservice.
- Support for Slave in eredis_cluster HOT 1
- exit messages {'EXIT',<0.13696.0>,normal}
- Can support SSL?
- Spawned reconnect_loop process is not terminated when the client is terminated
- ipv6 support cause issues in some cases HOT 1
- :nxdomain when using redis cluster endpoint with large number of shards
- Poor performance of Multi Bulk response parser HOT 1
- This source code is no longer the official. Please highlight this in README.
- eason: {timeout_value,[{ error
- Can not clone repository
- deadloop in reconnect_loop HOT 1
- TLS Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eredis.