Comments (1)
I think there is still a possible race condition.
- We call Client ! {connection_ready, Socket}.
- Client receive a redis command waiting in the mailbox.
- [Client ! M || M <- Msgs] is called with tcp_closed message.
Maybe we should send connection_ready only if Msgs is empty?
reconnect_loop(Client, #state{reconnect_sleep = ReconnectSleep} = State) ->
case catch(connect(State)) of
{ok, #state{socket = Socket}} ->
gen_tcp:controlling_process(Socket, Client),
case get_all_messages([]) of
[] ->
Client ! {connection_ready, Socket};
_ ->
timer:sleep(ReconnectSleep),
reconnect_loop(Client, State);
{error, _Reason} ->
timer:sleep(ReconnectSleep),
reconnect_loop(Client, State);
%% Something bad happened when connecting, like Redis might be
%% loading the dataset and we got something other than 'OK' in
%% auth or select
_ ->
timer:sleep(ReconnectSleep),
reconnect_loop(Client, State)
end.
from eredis.
Related Issues (20)
- authenticate fail , wrong password.
- Error after running test HOT 7
- Is there any method like qp_noreply? HOT 1
- Getting wrong value for HINCRBYFLOAT
- {error,{unexpected_data,{error,closed}}} - during Authentication HOT 1
- Don't log error on start HOT 1
- eredis Crash is killing my microservice.
- Support for Slave in eredis_cluster HOT 1
- exit messages {'EXIT',<0.13696.0>,normal}
- Can support SSL?
- Spawned reconnect_loop process is not terminated when the client is terminated
- ipv6 support cause issues in some cases HOT 1
- :nxdomain when using redis cluster endpoint with large number of shards
- Poor performance of Multi Bulk response parser HOT 1
- This source code is no longer the official. Please highlight this in README.
- eason: {timeout_value,[{ error
- Can not clone repository
- deadloop in reconnect_loop HOT 1
- TLS Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eredis.