Giter Club home page Giter Club logo

enhanced-boss-bars's People

Contributors

duncathan avatar kittenchilly avatar ma-rcx avatar wofsauge avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

enhanced-boss-bars's Issues

Error while fighting Delirium

"MC_HUD_RENDER" from "Enhanced Boss bars" failed: ...saac Rebirth/mods/enhanced boss bars_2635267643/main.lua:580: attempt to perform arithmetic on a nil value (field 'sumHP')
Stack Traceback:
  ...saac Rebirth/mods/enhanced boss bars_2635267643/main.lua:580: in function 'getHPPercent'
  ...saac Rebirth/mods/enhanced boss bars_2635267643/main.lua:626: in function at line 595

Note: was played with my Deep Labs compatibility mod installed, and boss-specific styles disabled. Unclear whether it played a part. Boss bars appeared to remain functional - perhaps related to the multitude of bosses spawning and despawning during that fight?

Selecting presets in MCM behaves strangely

Open MCM, go to presets, and press right repeatedly. The selection will toggle between Default and Antibirth, skipping Vanilla. Press left repeatedly, and the selection will toggle between Vanilla and Antibirth, skipping Default.

Boss icon coloring can be wrong

When the boss take damage when it appear, the Bar icon take the color of the damaging boss, with the red color. I assume it is because on the first frame you apply the boss color on the boss icon bar.
This can be reproduced easily with "Toxic Shock".

[Oversight] Friendly Bosses Have Healthbars

As the title says. When using Delirious or otherwise obtaining a friendly boss, its healthbar appears alongside the others, which can easily cause confusion when actually fighting a boss.

Boss bars are displayed even when EntityFlag.FLAG_DONT_COUNT_BOSS_HP is set to true

Hey there, I'm the developer for the mod "Delirium Fix" and I use the EntityFlag "FLAG_DONT_COUNT_BOSS_HP" to hide the extra boss bars during the Delirium fight. It looks like this without the Enhanced Boss Bars mod:
image

However, when the Enhanced Boss Bars mod is installed, it looks like this:
image

I believe this is a bug because a boss with the flag FLAG_DONT_COUNT_BOSS_HP is supposed to hide the boss bar.

In order to fix this bug, you just have to change line 322 of main.lua to
if (entity:IsBoss() and not HPBars:evaluateEntityIgnore(entity) or bossEntry) and not entity:HasEntityFlags(EntityFlag.FLAG_DONT_COUNT_BOSS_HP) then

And everything should look normal, like this:
image

Boss Bars during the Mega Satan fight

During the mega satan fight other spawned bosses, such as the sins, horsemen and angels all have health bars, even if the mega satan health bar has been disabled.

Also, mega satan 2 health bar shows up, even if the mega satan health bar is disabled, which definitely should not occur.

Boss bar often loses its colour

Just a small thing I've noticed, occasionally the boss bar seems to just turn grey, I believe after the boss hasn't taken any damage for a short period. I noticed the bar sprites themselves are grey internally and presumably have the colour added via Lua or something, so I imagine the problem is likely to do with that. Note that I haven't used the latest update, and won't be due to dropping this mod since it gives me more info than I'd like. Here's some settings, in case it's important:

  • Bar style: HesitantHatterene
  • Specific boss bars: Disabled
  • Position: Bottom
  • Icons: Enabled
  • Flashing: Enabled
  • Boss-specific bars (Dark Esau, Beast, Mother, Mega Satan): All Disabled
  • Info Text: None

If this issue is difficult to replicate, I do have a good number of mods (though most are just graphical replacements), so an unexpected compatibility issue is not out of the question.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.