Giter Club home page Giter Club logo

Comments (14)

amilan17 avatar amilan17 commented on August 11, 2024

@wmo-im/tt-tdcf -- please see Sebastien's questions and contribute to discussion in issues.

from grib2.

sebvi avatar sebvi commented on August 11, 2024

@wmo-im/tt-tdcf WE really would like to have a definitive answer on this. Should I organize a separate meeting with those interested so that we can reach an agreement/consensus?

from grib2.

jbathegit avatar jbathegit commented on August 11, 2024

Hello @sebvi and @amilan17. My vote would also be for the last option. I'm not sure of the original intent, but at this point I see no practical reason to deprecate and move a bunch of entries from category 20 to 13. Furthermore, having everything in one table (category 20) makes the most sense to me going forward, especially given your point about how the same template components are already planned to be used in GRIB3 for both aerosols and chemical constituents.

from grib2.

etoyoda avatar etoyoda commented on August 11, 2024

Dear Sebastian,

Chair Jitsuko called me to respond.

From the conclusion I'm in line with your later option.

I'm relatively old in this group, but even I don't know the actual debate to separate (only the name of) the code tables 4.230 and 4.233. When I came to the group the situation is basically the same: we had PDTs for chemical constituents (PDT 4.40-43) and those for aerosols (PDT 4.44-47) and both shared the same CCT-14 for identification of particles or molecules. And the expert team was discussing to create new Aerosol template 4.48.

My understanding is the choice of the template depends on the metadata we have: please note PDT's 4.44-48 can describe the size of particles and PDT's 4.40-43 cannot. We could use chemical PDT if we don't have information on particle size.
(see https://docs.google.com/spreadsheets/d/1nBFJTUt3Qld3fXwtS-W_yoPDYLOeMYiToicZAkdDiFw/edit?usp=sharing if some of you don't know the templates)

The category 13 has long been puzzle for me. The units of parameter zero is code table 4.205. That means the data section describes different type of atmospheric constituents depending on the grid. I cannot imagine real use case to have data like "dust at Beijing, sulphate at Tokyo, volcanic ash at Manila".

I have no problem to stop populating the category 13, and I can live with calling it discouraged or deprecated, but we have tradition to be really careful to remove something in the code form.

Best Regards,
Eizi TOYODA, Japan Meteorological Agency

from grib2.

sebvi avatar sebvi commented on August 11, 2024

Dear @jbathegit and @etoyoda ,

Thank you both for your comments.

It seems to me that we all agree and that we should stop using and updating discipline 0, category 13 within the Code Table 4.2

@jitsukoh : How should we proceed from here to "retire" category 13 and use only category 20?

from grib2.

jitsukoh avatar jitsukoh commented on August 11, 2024

@sebvi I agree with the way forward. Procedure-wise, we can add a note to category 13 saying that this category has stopped being populated in the PDF version. I am not sure about the existing entry (0 Aerosol type). If we "deprecate" it, we need to suggest an alternative way, like "use xxx instead." What do you think?
@amilan17 is there a way to add a note to whole category 13 in CSV on github?

from grib2.

amilan17 avatar amilan17 commented on August 11, 2024

@jitsukoh -- we can only reference notes for particular codes within a table. However, we will be able to manage this in the new (upcoming) notes.csv file, which will identify the scope of the note (code, table...).

from grib2.

amilan17 avatar amilan17 commented on August 11, 2024

@sebvi -- add a sentence for the note that should be added to the manual

from grib2.

amilan17 avatar amilan17 commented on August 11, 2024

@sebvi @jitsukoh please review the note. In the manual, It will be between the title and the table. 

Note: This category is deprecated, please use "Product discipline 0 – Meteorological products, parameter category 20: atmospheric chemical constituents" instead.

from grib2.

sebvi avatar sebvi commented on August 11, 2024

I am not sure about the note. Essentially the decision we are taking to stop using the category 13 and only add new parameter in category 20 is mainly for us in the Team. Users don't need to know, it is more a reminder for us.

On the note itself, I don't think we can use the word "deprecated". The unique entry 0 defined in category 13 is still perfectly valid to use and we don't provide an alternative encoding in category 20. Usually when we deprecate a parameter/table/template, it is because something is wrong and we usually point to a corrected alternative.

So the question is: Should we re-create "aerosol type" in category 20 and point to it as the alternative of category 13, entry 0? Note that at the moment, entry 0 is simply a bitmap/mask in disguise: 0=no aerosol, 1=some aerosol (see code table 4.205).

@wmo-im/tt-tdcf : please comment :)

from grib2.

jbathegit avatar jbathegit commented on August 11, 2024

I agree with @sebvi. I think this is more of an agreement among ourselves that we will no longer populate Category 13, but I agree that we can't deprecate it if there's no alternative to the existing entry 0. If we wanted to copy entry 0 into Category 20 and point users to that, then that would be an option, though I believe an unnecessary one because, as others have already pointed out, this is already set to be addressed within GRIB3.

from grib2.

amilan17 avatar amilan17 commented on August 11, 2024

ok. So no need to put a note in the manual.

from grib2.

jitsukoh avatar jitsukoh commented on August 11, 2024

@sebvi @jbathegit @amilan17 I agree with the word "deprecated." Existing codes should not be deprecated without alternatives. On the other hand, I think a note to indicate that this category will no longer be populated would be helpful, because not all users are our team members and also current members will not be there forever...
My proposal is "Note: This category is no longer populated, please use "Product discipline 0 – Meteorological products, parameter category 20: atmospheric chemical constituents" instead." Any suggestion would be appreciated.

from grib2.

jbathegit avatar jbathegit commented on August 11, 2024

Thanks @jitsukoh - adding your suggested note seems like a good and reasonable compromise approach, and I would support that.

Cc'ing @sebvi and @amilan17 in case they have any additional comments or thoughts.

from grib2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.